Add MTE-4138 - long press share actions tests #24242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against a87ee6b |
dragosb01
added
the
Do Not Merge ⛔️
|
Adding do not merge label to make share tests compatible with iOS 15 also. |
dragosb01
force-pushed
the
dbigu/MTE-4138
branch
from
6f4defb to
40c7098
Compare
dragosb01
force-pushed
the
dbigu/MTE-4138
branch
from
40c7098 to
a87ee6b
Compare
dragosb01
had a problem deploying
to
github-pages
GitHub Actions
Failure
dragosb01
removed
the
Do Not Merge ⛔️
clarmso
reviewed
Jan 21, 2025
| @@ -40,13 +40,176 @@ class ShareLongPressTests: BaseTestCase { | |||
| openNewTabAndValidateURLisPaste(url: "https://www") | |||
| } | |||
|
|
|||
| // https://mozilla.testrail.io/index.php?/cases/view/2864380 | |||
| func testBookmarksShareNormalWebsiteReminders() { | |||
| if #available(iOS 17, *) { | |||
There was a problem hiding this comment.
Yes, feel free to run the tests only on more recent versions of iOS.
clarmso
approved these changes
Jan 21, 2025
isabelrios
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
https://mozilla-hub.atlassian.net/browse/MTE-4138
💡 Description
Added long press share options test from bookmark, history and reading list.
Also did a couple of fixes to make the other share tests compatible with iOS 16 and 17.