Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix MTE-4133 Disable retries in fastlane #24251

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+46 −10
Open

Bugfix MTE-4133 Disable retries in fastlane #24251

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39e6d4a
Enable retries in fastlane
clarmso Jan 20, 2025
c5635bf
Hardcode xcbeautify as the formatter. It's the default on Bitrise
clarmso Jan 20, 2025
9a554a1
Sometimes we can open the tab tray
clarmso Jan 20, 2025
c2ab494
Create L10nSnapshotTests test plan. Enable test retries.
clarmso Jan 22, 2025
c54a8e1
Use test plan for L10n
clarmso Jan 22, 2025
c61388c
Use old wait for now.
clarmso Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions firefox-ios/l10n-screenshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ for lang in $LOCALES; do
echo "$(date) Snapshotting $lang"
mkdir "l10n-screenshots/$lang"
fastlane snapshot --project firefox-ios/Client.xcodeproj --scheme L10nSnapshotTests \
--number_of_retries 0 \
--number_of_retries 3 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if the default value has changed or not by reading the documentation. Let's hard code this value.

Copy link
Collaborator Author

@clarmso clarmso Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 testHistoryTableContextMenu failed. The whole list of tests are rerun. This may not be what we want.
https://app.bitrise.io/build/bc7e1954-3780-4157-afeb-51e10ad9ff3d?tab=log

Copy link
Contributor

@isabelrios isabelrios Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't want retries. Just one execution per locale no matter the reesult. Please see explanation here:https://mozilla.slack.com/archives/C02KSH6QNBS/p1737374666180979?thread_ts=1737374476.241319&cid=C02KSH6QNBS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is ignored now by fastlane. We should use set the retry opion to off from xcode and to do that, we need to create a test plan for the L10n schema where we can configure that. I have done that locally, forced a test to fail, and there are no retries.
Please try that and let me know in case you want a hack session to do that together.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a L10nSnapshotTests test plan and have the schema to use the test plan.

--skip_open_summary \
--xcargs "-maximum-parallel-testing-workers 2" \
--derived_data_path l10n-screenshots-dd \
Expand All @@ -46,7 +46,7 @@ for lang in $LOCALES; do
if [ "$?" != "0" ]; then
echo "Fastlane exited with code: $?"
exit $?
elif grep -q "** TEST FAILED **"; then
elif grep -q "TEST FAILED" "output.txt"; then
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"output.txt" was missing previously, so this line might not be working properly before.

echo "Test/compilation failed"
exit 1
elif grep -q "Caught error" "output.txt"; then
Expand Down