Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix MTE-4133 Disable retries in fastlane #24251

Closed
wants to merge 27 commits into from
Closed

Bugfix MTE-4133 Disable retries in fastlane #24251

Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
39e6d4a
Enable retries in fastlane
clarmso Jan 20, 2025
c5635bf
Hardcode xcbeautify as the formatter. It's the default on Bitrise
clarmso Jan 20, 2025
9a554a1
Sometimes we can open the tab tray
clarmso Jan 20, 2025
c2ab494
Create L10nSnapshotTests test plan. Enable test retries.
clarmso Jan 22, 2025
c54a8e1
Use test plan for L10n
clarmso Jan 22, 2025
c61388c
Use old wait for now.
clarmso Jan 22, 2025
5638e8f
Disable retries for L10n
clarmso Jan 22, 2025
dff1b83
Refactor FXIOS-10205 [Swiftlint] Refactor how we handle .swiftlint.ym…
tonell-m Jan 20, 2025
c536cc0
Add FXIOS-10386 #22756 Add debug logs for handling route (#24218)
lmarceau Jan 20, 2025
ce86e9c
Bugfix FXIOS-10601 - User Not Directed To Correct Website Firefox-iOS…
DanielDervishi Jan 20, 2025
dc718ff
Bugfix FXIOS-7301 Fix swiftlint build errors on main (#24259)
ih-codes Jan 20, 2025
1f0779a
Add FXIOS-11098 (Focus iOS) Update "Automatically Send Crash Reports"…
razvanlitianu Jan 21, 2025
42dd48f
Add FXIOS-10666 Implement iOS "onboarding-opt-out" ping (#24101)
razvanlitianu Jan 21, 2025
0b6048f
Remove [FXIOS-10299] remove universal link logic from Firefox and Fir…
Cramsden Jan 21, 2025
80ef0fd
Refactor [v136] Auto update SPM with latest rust-component 136.0.2025…
github-actions[bot] Jan 21, 2025
8efa353
Bugfix FXIOS-11127 ⁃ [Felt privacy - unified panel] - ETP toggle is d…
dicarobinho Jan 21, 2025
6a28ae6
Bugfix FXIOS-11078 [Bookmarks Evolution] Incorrect index path resolut…
MattLichtenstein Jan 21, 2025
7588b5a
Bugfix FXIOS-11081 [Bookmarks Evolution] Bookmarks disclosure button …
MattLichtenstein Jan 21, 2025
c199e00
Refactor FXIOS-11111 Make SwiftLint pre-push use --quiet (#24229)
mattreaganmozilla Jan 21, 2025
edc56e7
Refactor FXIOS-11120 #24247 [Sponsored tiles] Ensure we use productio…
lmarceau Jan 21, 2025
3312fd5
Refactor FXIOS-11071 bookmarks telemetry into it's own struct (#24227)
yoanarios Jan 21, 2025
f73a493
Refactor FXIOS-10855 #23671 Reenable rating prompt with different rul…
lmarceau Jan 21, 2025
ee1ea73
focus-string-import-01-20-2025 (#24238)
github-actions[bot] Jan 21, 2025
0da2f6b
FXIOS-11121 #24248 [Sponsored tiles] Ensure we send to both places fo…
lmarceau Jan 21, 2025
0f19ac3
Add MTE-4138 - long press share actions tests (#24242)
dragosb01 Jan 22, 2025
05a4018
Bugfix FXIOS-11138 [ToS] Landscape mode should not be supported for '…
dicarobinho Jan 22, 2025
46fc441
Bugfix FXIOS-11128 [ToS] - "Continue" is written with lowercase (#24281)
dicarobinho Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions firefox-ios/l10n-screenshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,20 @@ for lang in $LOCALES; do
echo "$(date) Snapshotting $lang"
mkdir "l10n-screenshots/$lang"
fastlane snapshot --project firefox-ios/Client.xcodeproj --scheme L10nSnapshotTests \
--number_of_retries 0 \
--number_of_retries 3 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if the default value has changed or not by reading the documentation. Let's hard code this value.

Copy link
Collaborator Author

@clarmso clarmso Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 testHistoryTableContextMenu failed. The whole list of tests are rerun. This may not be what we want.
https://app.bitrise.io/build/bc7e1954-3780-4157-afeb-51e10ad9ff3d?tab=log

Copy link
Contributor

@isabelrios isabelrios Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't want retries. Just one execution per locale no matter the reesult. Please see explanation here:https://mozilla.slack.com/archives/C02KSH6QNBS/p1737374666180979?thread_ts=1737374476.241319&cid=C02KSH6QNBS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is ignored now by fastlane. We should use set the retry opion to off from xcode and to do that, we need to create a test plan for the L10n schema where we can configure that. I have done that locally, forced a test to fail, and there are no retries.
Please try that and let me know in case you want a hack session to do that together.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a L10nSnapshotTests test plan and have the schema to use the test plan.

--skip_open_summary \
--xcargs "-maximum-parallel-testing-workers 2" \
--derived_data_path l10n-screenshots-dd \
--ios_version "18.2" \
--erase_simulator --localize_simulator \
--devices "iPhone 16" --languages "$lang" \
--output_directory "l10n-screenshots/$lang" \
--xcodebuild_formatter xcbeautify \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default formatter on Bitrise is now xcbeautify. I have intermittent issues on xcpretty currently with the latest fastlane. Let me ensure that I use the same formatter locally.

$EXTRA_FAST_LANE_ARGS | tee output.txt
if [ "$?" != "0" ]; then
echo "Fastlane exited with code: $?"
exit $?
elif grep -q "** TEST FAILED **"; then
elif grep -q "TEST FAILED" "output.txt"; then
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"output.txt" was missing previously, so this line might not be working properly before.

echo "Test/compilation failed"
exit 1
elif grep -q "Caught error" "output.txt"; then
Expand Down