Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10904 Focus iOS: Send data deletion request when DAU ping is toggled off #24339

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions focus-ios/Blockzilla/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ extension AppDelegate {
}
}

GleanMetrics.Pings.shared.usageDeletionRequest.setEnabled(enabled: true)

if TelemetryManager.shared.isGleanEnabled {
UsageProfileManager.checkAndSetUsageProfileId()
} else {
Expand All @@ -371,6 +373,7 @@ extension AppDelegate {
channel: channel,
pingSchedule: ["baseline": ["usage-reporting"]]
)

Glean.shared.initialize(
uploadEnabled: TelemetryManager.shared.isGleanEnabled,
configuration: configuration,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,9 @@ class SettingsViewController: UIViewController, UITableViewDataSource, UITableVi
} else if toggle.setting == .biometricLogin {
TipManager.biometricTip = false
} else if toggle.setting == .dailyUsagePing {
// TODO: FXIOS-10904 Focus iOS: Send data deletion request when DAU ping is toggled off
if !sender.isOn {
GleanMetrics.Pings.shared.usageDeletionRequest.submit()
}
}

switch toggle.setting {
Expand Down
23 changes: 23 additions & 0 deletions focus-ios/Blockzilla/pings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,26 @@ usage-reporting:
include_info_sections: false
ping_schedule:
- baseline

usage-deletion-request:
description: |
This ping is submitted when a user opts out of sending usage
frequency of Firefox to Mozilla.
Sent in response to user action.
include_client_id: false
send_if_empty: true
bugs:
- https://mozilla-hub.atlassian.net/browse/FXIOS-10904
data_reviews:
- https://github.com/mozilla-mobile/firefox-ios/pull/24339
notification_emails:
- [email protected]
- [email protected]
- [email protected]
metadata:
follows_collection_enabled: false
include_info_sections: false
reasons:
set_upload_enabled: |
The ping was submitted due to the usage-reporting data preference changing from
enabled to disabled.