Skip to content

Add [Tab Loss] Add info to tab restore logs to see if the app previously crashed #27150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cramsden
Copy link
Contributor

@Cramsden Cramsden commented Jun 6, 2025

💡 Description

I noticed that Sentry has some information about if the app crashed at last launch. I was hoping by adding this information to the tab restore log we might understand if the reason we are restoring tabs so often is connected to the app crashing or not.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@Cramsden Cramsden requested a review from a team as a code owner June 6, 2025 14:13
@Cramsden Cramsden requested review from issammani, FilippoZazzeroni and mattreaganmozilla and removed request for issammani June 6, 2025 14:13
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.34%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 35.47

File Coverage
TabManagerImplementation.swift 51.85%

Generated by 🚫 Danger Swift against 3e72b32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants