Skip to content

Refactor FXIOS-12472 [Support utils] Clean up URLs to use SupportUtils #27192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Refactor FXIOS-12472 [Support utils] Clean up URLs to use SupportUtils #27192

merged 1 commit into from
Jun 12, 2025

Conversation

lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Jun 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Noticed we were not using SupportUtils class for some of our support URLs, so went to fix that!

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner June 9, 2025 14:57
@lmarceau lmarceau requested a review from issammani June 9, 2025 14:57
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.84%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 35.48

File Coverage
OpenSupportPageSetting.swift 0.0% ⚠️
EmptyPrivateTabsView.swift 92.62% ✅
ExperimentEmptyPrivateTabsView.swift 0.0% ⚠️
MainMenuActionHelper.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against f1a2ba5

@lmarceau lmarceau merged commit c317b9c into main Jun 12, 2025
8 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-12472-support-utils branch June 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

@issammani issammani Awaiting requested review from issammani issammani is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmarceau @mobiletest-ci-bot @thatswinnie