Skip to content

Add FXIOS-12301 [Context ID] Integrate with rust context id rotation component #27195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cramsden
Copy link
Contributor

@Cramsden Cramsden commented Jun 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Collab with @issammani

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

}

func rotated(oldContextId: String) {
// NO-OP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see GleanPings.contextIdDeletionRequest.submit(); commented in there. Will that ContextIDManager support deleting the context id? I had some discussion with Mike Conley (summary noted in https://mozilla-hub.atlassian.net/browse/FXIOS-11783), and we're not deleting the local context_id even when toggling off interaction data but we should. Happy to discuss in coffee chat to give more context (pun intended 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants