Skip to content

Refactor FXIOS-12469 [TA 2025] Update MockGleanWrapper functionality to test extras from multiple events fired in a single test #27197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

ih-codes
Copy link
Collaborator

@ih-codes ih-codes commented Jun 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR updates our MockGleanWrapper to allow telemetry unit tests to capture extras from multiple events by making the extras an array. Also removes the unnecessary optional on the wrapper's events array.

Updated all the tests for these changes (trivial text replacements).

This is in preparation of being able to add unit tests for code that fires multiple events where we want to inspect the extras.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@ih-codes ih-codes requested a review from a team as a code owner June 9, 2025 21:10
@ih-codes ih-codes requested a review from razvanlitianu June 9, 2025 21:10
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 18 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 8999be9

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in MockGleanWrapper looks good! thanks for making this update!

@ih-codes ih-codes merged commit 76033ba into main Jun 11, 2025
11 checks passed
@ih-codes ih-codes deleted the ih/FXIOS-12469-MockGleanWrapper-multiple-event-extras branch June 11, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants