Skip to content

Add FXIOS-12426 #27088 ⁃ Cookie handling improvements and lost detection #27198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yoanarios
Copy link
Contributor

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

  • Initial commit adding UITest to detect cookie problems
  • Add test HTML page with cookies, simulating login and other cookies
  • Add test that loads test page logs in and checks state then relaunch the app and check that the state is Log in still.
    Next step is to make it fail. I tried reverting the fix for the latest cookie issue and is not enough to make the test fail. I think we need to do more steps like add a new tab to force the select tab flow.

πŸŽ₯ Demos

Before After
Demo

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@yoanarios yoanarios requested a review from isabelrios June 9, 2025 21:20
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jun 9, 2025

Messages
πŸ“– Project coverage: 35.83%
πŸ“– Edited 2 files
πŸ“– Created 2 files

Client.app: Coverage: 35.39

File Coverage
WebServerUtil.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 1071a7d

@yoanarios yoanarios force-pushed the yrd/FXIOS-12426-fix-cookies branch 2 times, most recently from 2125d73 to 1141c06 Compare June 11, 2025 15:33
mozWaitForElementToExist(webview.staticTexts["LOGGED_IN"])

// Open a few tabs
websites.forEach { website in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabelrios In this step I'm trying to open a few tabs to go through the process of creating a tab, selecting etc, which has caused cookie issues in the past, but the test is not passing locally because it is not typing the address I'm not sure what I'm missing

@yoanarios yoanarios force-pushed the yrd/FXIOS-12426-fix-cookies branch from 1141c06 to 1071a7d Compare June 12, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants