Bugfix FXIOS-12489 [Tab tray UI experiment] Disable swipe when drag and drop happens #27225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/v140 |
✅ Backports have been created
|
Foxbolts
approved these changes
Jun 11, 2025
Client.app: Coverage: 35.42
Generated by 🚫 Danger Swift against 9a91db2 |
7 tasks
lmarceau
added a commit
that referenced
this pull request
Jun 11, 2025
…nd drop happens (backport #27225) (#27260) * Bugfix FXIOS-12489 [Tab tray UI experiment] Disable swipe when drag and drop happens (#27225) * Disable swipe when drag and drop happens * Adjust unit tests (cherry picked from commit fe1e53e) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj * Fix conflicts --------- Co-authored-by: lmarceau <[email protected]>
lmarceau
added a commit
that referenced
this pull request
Jun 12, 2025
…27292) * Revert "Bugfix FXIOS-12489 [Tab tray UI experiment] Disable swipe when drag and drop happens (#27225)" This reverts commit fe1e53e. * Disable drag and drop on tab tray with experiment
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…27292) * Revert "Bugfix FXIOS-12489 [Tab tray UI experiment] Disable swipe when drag and drop happens (#27225)" This reverts commit fe1e53e. * Disable drag and drop on tab tray with experiment (cherry picked from commit 9563b5c) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj
lmarceau
added a commit
that referenced
this pull request
Jun 12, 2025
…backport #27292) (#27294) * Refactor FXIOS-12520 [Tab tray UI experiment] Disable drag and drop (#27292) * Revert "Bugfix FXIOS-12489 [Tab tray UI experiment] Disable swipe when drag and drop happens (#27225)" This reverts commit fe1e53e. * Disable drag and drop on tab tray with experiment (cherry picked from commit 9563b5c) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj * Fix conflict --------- Co-authored-by: lmarceau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Disabling the swipe when we are drag and dropping a tab cell. It breaks the tab tray otherwise.
📝 Checklist
@Mergifyio backport release/v120)