Refactor FXIOS-13352 [Tab Manager] Fix delay in “Close All Tabs” action (#29046) #29717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR refactors the “Close All Tabs” flow to fix the visual delay reported in #29046.
isClosingAllTabs
flag to ensure the flow only fires once.launchCloseAllTabsAnimation()
now starts the close-all animation immediately on the next main-queue turn, dismissing alerts first and deferring the actual purge untilfinishClosingAllTabs()
runs after the animation completes.performCloseAllTabsAnimation
inTabDisplayView
to provide a consistent scale/fade transition, skip the effect if Reduce Motion is enabled, and restore cell state if interrupted.removeAllTabs
to batch tab removals:flushToDisk: false
), then commit changes once.Result: Animations begin instantly when the user confirms, persistence and undo handling are more efficient, and main-thread blocking from repeated disk flushes is eliminated.
📝 Checklist