Skip to content

Conversation

issammani
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

  • Adds use_local_as.sh script to automate building and comsuming an AS build.
  • The steps on the script roughly map to the manual flow as described in [1] and [2]

⚠️ Will update the wiki we have on iOS since it's very outdated after this merges.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@issammani issammani requested review from cyndichin and skhamis October 7, 2025 13:12
@issammani issammani marked this pull request as ready for review October 7, 2025 13:12
@issammani issammani requested a review from a team as a code owner October 7, 2025 13:12
@mobiletest-ci-bot
Copy link

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against d130fe9

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running script shows me a successful log, let me know if I should be testing anything else. I'll let @skhamis review the script itself. Nothing stands out to me. Thanks for adding the comments

image

Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the PR @issammani! Had one thought about maybe splitting the scripts but let me know if you feel strongly against that. Overall does look good though!

log "Using NSS_DIR=$NSS_DIR"
log "Using NSS_STATIC=$NSS_STATIC"

###############################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! However I wonder if we should potentially split the scripts here. I think for most people regularly doing dev on a-s -> iOS, most of the above script is not necessarily needed. Starting from here is really the (awesome) driver that most devs would be interested in. Should we split the above to go in some kinda "appservices_bootstrap" and the below is actual use_local_as.sh? That might make it easier to maintain in the future.

Also I do worry a little about when appservices moves to monorepo the above might change in some form. I'm half wondering if there should be something like "go to X to see the set-up for appservices" or something like that. However that can be tweaked in the future as we try to get the flow more stable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants