Skip to content

Conversation

isabelrios
Copy link
Contributor

📜 Tickets

Jira ticket

💡 Description

This PRs removes all UI tests we have with TabTray Experiment value OFF because the default value is ON for all users.
WIth that we will reduce the number of tests running since they are not needed anymore

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@isabelrios
Copy link
Contributor Author

Initial work on this, note we need to remove all those test names from the test plans files

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 9, 2025

Messages
📖 Project coverage: 38.48%

💪 Quality guardian

23 tests files modified. You're a champion of test coverage! 🚀

🧟‍♂️ Monster PR

Wow, this PR is huge with 2525 lines changed!
Thanks for powering through such a big task 🙌.
Reviewers: feel free to ask for extra context, screenshots, or a breakdown to make reviewing smoother.

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.22

File Coverage
SummarizeCoordinator.swift 96.91%

Generated by 🚫 Danger Swift against fea0cbd

Copy link
Contributor

mergify bot commented Oct 15, 2025

This pull request has conflicts when rebasing. Could you fix it @isabelrios? 🙏

@dragosb01 dragosb01 force-pushed the irios-mte-4921-disable-tabtray-tests-experiment-off branch 2 times, most recently from 7ff5ff2 to 82c04a0 Compare October 15, 2025 07:53
Copy link
Contributor

mergify bot commented Oct 15, 2025

This pull request has conflicts when rebasing. Could you fix it @isabelrios? 🙏

@dragosb01 dragosb01 force-pushed the irios-mte-4921-disable-tabtray-tests-experiment-off branch from 82c04a0 to 6bc1f2d Compare October 15, 2025 08:34
@dragosb01 dragosb01 force-pushed the irios-mte-4921-disable-tabtray-tests-experiment-off branch 2 times, most recently from 698123d to 21de88b Compare October 15, 2025 08:47
@isabelrios isabelrios marked this pull request as ready for review October 15, 2025 10:27
@isabelrios isabelrios requested review from a team as code owners October 15, 2025 10:27
@dragosb01 dragosb01 force-pushed the irios-mte-4921-disable-tabtray-tests-experiment-off branch from 21de88b to fea0cbd Compare October 15, 2025 11:06
Copy link
Contributor

@mdotb-moz mdotb-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isabelrios isabelrios merged commit 963eff7 into main Oct 15, 2025
9 checks passed
@isabelrios isabelrios deleted the irios-mte-4921-disable-tabtray-tests-experiment-off branch October 15, 2025 15:17
Copy link
Contributor

🚀 PR merged to main, targeting version: 144.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants