Skip to content

Conversation

cyndichin
Copy link
Contributor

@cyndichin cyndichin commented Oct 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Draft PR to explore adding the translate button on the toolbar. It's messy and need to clean up things (+FF), but can work on it for now. Also, need to add machine gun haptics.

Simulator.Screen.Recording.-.iPhone.16e.-.2025-10-09.at.15.03.21.mov

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@cyndichin cyndichin requested a review from issammani October 9, 2025 19:04
@cyndichin cyndichin added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Oct 9, 2025
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 38.3%

✍️ Strings Updated

Detected changes in Shared/Strings.swift.
To keep strings up to standards, please tag a member of the firefox-ios-l10n team for review. 🌍

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.27

File Coverage
AddressToolbarContainerModel.swift 87.12%
ToolbarActionConfiguration.swift 100.0%
AddressBarState.swift 96.16%
ToolbarState.swift 91.63%
ToolbarAction.swift 100.0%
NimbusFlaggableFeature.swift 95.45%
NimbusFeatureFlagLayer.swift 77.49%
ToolbarMiddleware.swift 91.28%

ToolbarKit: Coverage: 63.22

File Coverage
ToolbarButton.swift 63.46%

Generated by 🚫 Danger Swift against 9b27802

@thatswinnie thatswinnie self-requested a review October 13, 2025 07:39
Copy link
Contributor Author

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be used to make a nightly build and should not be merged into main.

The images are still TBD and are not following the proper StandardImageIdentifiers and ImageIdentifiers convention. Awaiting designer to confirm with acorn team.

Copy link
Contributor

mergify bot commented Oct 15, 2025

This pull request has conflicts when rebasing. Could you fix it @cyndichin? 🙏

@cyndichin cyndichin force-pushed the cc/FXIOS-13816_mvp-with-translations-icon branch from 9b27802 to 296c932 Compare October 15, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants