Skip to content

Refactor FXIOS-13815 [Relay] Swift wrapper for getAttachedClients#30008

Merged
mattreaganmozilla merged 1 commit intomozilla-mobile:mainfrom
mattreaganmozilla:mr/13815
Oct 15, 2025
Merged

Refactor FXIOS-13815 [Relay] Swift wrapper for getAttachedClients#30008
mattreaganmozilla merged 1 commit intomozilla-mobile:mainfrom
mattreaganmozilla:mr/13815

Conversation

@mattreaganmozilla
Copy link
Collaborator

@mattreaganmozilla mattreaganmozilla commented Oct 14, 2025

📜 Tickets

Jira ticket

💡 Description

Swift wrapper getAttachedClients

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mattreaganmozilla mattreaganmozilla requested a review from a team as a code owner October 14, 2025 22:34
@mobiletest-ci-bot
Copy link

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
MozillaRustComponents/Sources/MozillaRustComponentsWrapper/FxAClient/FxAccountManager.swift 0.0% 35.0%

Generated by 🚫 Danger Swift against 1a290cc

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚢

@mattreaganmozilla mattreaganmozilla merged commit 2925f35 into mozilla-mobile:main Oct 15, 2025
11 checks passed
@github-actions
Copy link
Contributor

🚀 PR merged to main, targeting version: 144.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants