Skip to content

Conversation

@cyndichin
Copy link
Contributor

@cyndichin cyndichin commented Oct 27, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

This reverts commit 0938097. This is due to this PR being merged but it seems the original changes were overwritten for a suggested fix for another issue.

As you can see from the PR, the changes are unrelated to the PR description.

Since the code that was merged has not been reviewed, we want to undo these changes in main.

cc: @Rinwaoluwa

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@cyndichin cyndichin requested a review from lmarceau October 27, 2025 16:40
@cyndichin cyndichin requested a review from a team as a code owner October 27, 2025 16:40
@cyndichin cyndichin requested a review from issammani October 27, 2025 16:48
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 38.29%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

🎉 BrowserViewController got smaller

Nice! BrowserViewController.swift got smaller by 5 lines.

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.27

File Coverage
BrowserViewController.swift 32.03% ⚠️

Generated by 🚫 Danger Swift against 40b28db

@cyndichin cyndichin merged commit cdcc6d1 into main Oct 27, 2025
9 checks passed
@cyndichin cyndichin deleted the cc/FXIOS-29807_revert-glean-PR-that-has-other-changes branch October 27, 2025 17:14
@github-actions
Copy link
Contributor

🚀 PR merged to main, targeting version: 145.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants