Add FXIOS-13799 - Update keyboard's accessory view for iOS 26 #30339
Conversation
|
This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏 |
💪 Quality guardian2 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ 🦊 BrowserViewController CheckWe’re tracking the size of
❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.02
ToolbarKit: Coverage: 62.78
Generated by 🚫 Danger Swift against 6a928da |
There was a problem hiding this comment.
Tested locally and seems to be working well! 👍 I'll defer to @thatswinnie since she has more context on the task at hand after reviewing the initial PR.
|
This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏 |
PARAIPAN9
deleted the
paraipan/fxios-13799-Toolbar-accessory-view-ios26-update-2
branch
|
🚀 PR merged to |
| if isEditing { | ||
| store.dispatch(ToolbarAction(windowUUID: windowUUID, | ||
| actionType: ToolbarActionType.hideKeyboard)) | ||
| store.dispatchLegacy( |
There was a problem hiding this comment.
🚫 dispatchLegacy 🚫 I'll remove it in my next PR, but let's not add new ones please! 🙏
There was a problem hiding this comment.
I added it by mistake after solving a conflict. Sorry.
There was a problem hiding this comment.
It's easy to add them back in since we don't use @available(*, deprecated) 😢
There was a problem hiding this comment.
I'll add a Danger check for now #30420 so we have an interim solution
📜 Tickets
Jira ticket
Github issue
💡 Description
scrollAlphaNeedsUpdateaction tokeyboardWillHideWithState.offsetForKeyboardAccessory.📝 Checklist