Skip to content

Update FXIOS-13834 UI test #30351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −3
Draft

Update FXIOS-13834 UI test #30351

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bde2060
Remove flag
clarmso Nov 3, 2025
fab15c8
disable testQuickSearchEngines
clarmso Nov 3, 2025
05023e6
Just deal with the UI tests for now. Don't worry about unit tests
clarmso Nov 5, 2025
9ed04f0
fix comment?
clarmso Nov 5, 2025
b7e5689
oops syntax error
clarmso Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions firefox-ios/Client/Frontend/Browser/SearchEngines/SearchEngineFlagManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ import Common
struct SearchEngineFlagManager {
/// Whether Search Engine Consolidation is enabled.
/// If enabled, search engines are fetched from Remote Settings rather than our pre-bundled XML files.
/// TODO: [FXIOS-13834 & 11403] Remove hardcoded override once UI & unit tests are updated (or deleted)
guard !AppConstants.isRunningUnitTest { return false }
static var isSECEnabled: Bool {
// TODO: [FXIOS-13834 & 11403] Remove hardcoded override once UI & unit tests are updated (or deleted)
guard !AppConstants.isRunningUnitTest && !AppConstants.isRunningUITests else { return false }

// SEC enabled for all users. Related clean-up forthcoming in [FXIOS-11403].
return true
}
Expand Down