Skip to content

Refactor FXIOS-12796 [Swift 6 Migration] Fix Sendable warnings in CreditCardSettingsViewModel and CreditCardInputViewModel #30354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Refactor FXIOS-12796 [Swift 6 Migration] Fix Sendable warnings in CreditCardSettingsViewModel and CreditCardInputViewModel #30354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Client/Frontend/Autofill/CreditCard/CreditCardSettingsView/CreditCardInputViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ class CreditCardInputViewModel: ObservableObject {
}

func removeCreditCard(creditCard: CreditCard?,
completion: @escaping (CreditCardModifiedStatus, Bool) -> Void) {
completion: @escaping @Sendable (CreditCardModifiedStatus, Bool) -> Void) {
guard let currentCreditCard = creditCard,
!currentCreditCard.guid.isEmpty else {
completion(.none, false)
Expand Down
5 changes: 3 additions & 2 deletions ...ent/Frontend/Autofill/CreditCard/CreditCardSettingsView/CreditCardSettingsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ enum CreditCardSettingsState: String, Equatable, CaseIterable {
case list = "List"
}

class CreditCardSettingsViewModel {
// FIXME: FXIOS-14006 Class is not thread safe
final class CreditCardSettingsViewModel: @unchecked Sendable {
var autofill: RustAutofill?
var profile: Profile
let windowUUID: WindowUUID
Expand Down Expand Up @@ -67,7 +68,7 @@ class CreditCardSettingsViewModel {
}
}

func getCreditCardList(_ completionHandler: @escaping ([CreditCard]?) -> Void) {
func getCreditCardList(_ completionHandler: @escaping @Sendable ([CreditCard]?) -> Void) {
autofill?.listCreditCards(completion: { creditCards, error in
guard let cards = creditCards,
error == nil else {
Expand Down