Skip to content

Add FXIOS-14009 Add binary symbol stripping build phase script for Firefox configuration #30361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −1
Open

Add FXIOS-14009 Add binary symbol stripping build phase script for Firefox configuration #30361

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6db8473
Add binary symbols stripping build phase script
NicoHinderling Nov 4, 2025
1d3ccf3
include required input file
NicoHinderling Nov 4, 2025
ac4ecdb
move input file to correct path
NicoHinderling Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion firefox-ios/Client.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16790,6 +16790,7 @@
E6639F191BF11E3A002D0853 /* Conditionally Add Optional Resources */,
E6B09CD31C74EEDB00C63FA1 /* Copy Frameworks */,
4368F81027955AE80013419B /* ShellScript */,
C31224262EB9944500683849 /* Strip Symbols */,
);
buildRules = (
);
Expand Down Expand Up @@ -17587,6 +17588,7 @@
inputFileListPaths = (
);
inputPaths = (
"${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${EXECUTABLE_NAME}",
Copy link
Collaborator

@thatswinnie thatswinnie Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the path for a different "Run Script" phase (not the newly added Strip Symbols one you added). Could you please add it to the correct build phase?

Copy link
Contributor Author

@NicoHinderling NicoHinderling Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops! 🙈 good catch

);
outputFileListPaths = (
);
Expand All @@ -17595,7 +17597,6 @@
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "movedFrameworks=()\n cd \"${CODESIGNING_FOLDER_PATH}/Frameworks/\"\n for framework in *; do\n if [ -d \"$framework\" ]; then\n if [ -d \"${framework}/Frameworks\" ]; then\n echo \"Moving nested frameworks from ${framework}/Frameworks/ to ${PRODUCT_NAME}.app/Frameworks/\"\n \n cd \"${framework}/Frameworks/\"\n for nestedFramework in *; do\n echo \"- nested: ${nestedFramework}\"\n movedFrameworks+=(\"${nestedFramework}\")\n done\n cd ..\n cd ..\n \n cp -R \"${framework}/Frameworks/\" .\n rm -rf \"${framework}/Frameworks\"\n fi\n fi\n done\n \n if [ \"${CONFIGURATION}\" == \"Debug\" ] & [ \"${PLATFORM_NAME}\" != \"iphonesimulator\" ] ; then\n for movedFramework in \"${movedFrameworks[@]}\"\n do\n codesign --force --deep --sign \"${EXPANDED_CODE_SIGN_IDENTITY}\" --preserve-metadata=identifier,entitlements --timestamp=none \"${movedFramework}\"\n done\n else\n echo \"Info: CODESIGNING is only needed for Debug on device (will be re-signed anyway when archiving) \"\n fi\n";
showEnvVarsInLog = 0;
};
45CC573928AD89CB006D55AA /* Glean SDK Generator Script */ = {
isa = PBXShellScriptBuildPhase;
Expand Down Expand Up @@ -17680,6 +17681,25 @@
shellPath = /bin/sh;
shellScript = "if [ \"$ACTION\" != \"indexbuild\" ]; then\n /usr/bin/env -i HOME=$HOME PROJECT=$PROJECT CONFIGURATION=$CONFIGURATION SOURCE_ROOT=$SOURCE_ROOT bash \"$SOURCE_ROOT/bin/nimbus-fml.sh\" --verbose\nfi\n\n";
};
C31224262EB9944500683849 /* Strip Symbols */ = {
isa = PBXShellScriptBuildPhase;
alwaysOutOfDate = 1;
buildActionMask = 2147483647;
files = (
);
inputFileListPaths = (
);
inputPaths = (
);
name = "Strip Symbols";
outputFileListPaths = (
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "#!/bin/bash\nset -e\n\nif [ \"Firefox\" = \"${CONFIGURATION}\" ]; then\n # Path to the app directory\n APP_DIR_PATH=\"${BUILT_PRODUCTS_DIR}/${EXECUTABLE_FOLDER_PATH}\"\n # Strip main binary\n strip -rSTx \"${APP_DIR_PATH}/${EXECUTABLE_NAME}\"\n # Path to the Frameworks directory\n APP_FRAMEWORKS_DIR=\"${APP_DIR_PATH}/Frameworks\"\n\n # Strip symbols from frameworks, if Frameworks/ exists at all\n # ... as long as the framework is NOT signed by Apple\n if [ -d \"${APP_FRAMEWORKS_DIR}\" ]\n then\n find \"${APP_FRAMEWORKS_DIR}\" -type f -perm +111 -maxdepth 2 -mindepth 2 -exec bash -c '\n codesign -v -R=\"anchor apple\" \"{}\" &> /dev/null ||\n (\n echo \"Stripping {}\" &&\n if [ -w \"{}\" ]; then\n strip -rSTx \"{}\"\n else\n echo \"Warning: No write permission for {}\"\n fi\n )\n ' \\;\n fi\n\n # Path to the PlugIns directory\n APP_PLUGINS_DIR=\"${APP_DIR_PATH}/PlugIns\"\n\n # Strip symbols from plugins, if PlugIns/ exists at all\n # ... as long as the plugin is NOT signed by Apple\n if [ -d \"${APP_PLUGINS_DIR}\" ]\n then\n find \"${APP_PLUGINS_DIR}\" -type f -perm +111 -maxdepth 2 -mindepth 2 -exec bash -c '\n codesign -v -R=\"anchor apple\" \"{}\" &> /dev/null ||\n (\n echo \"Stripping {}\" &&\n if [ -w \"{}\" ]; then\n strip -rSTx \"{}\"\n else\n echo \"Warning: No write permission for {}\"\n fi\n )\n ' \\;\n fi\nfi\n";
};
C874A4E327F62C5B006F54E5 /* Swiftlint */ = {
isa = PBXShellScriptBuildPhase;
alwaysOutOfDate = 1;
Expand Down