Remove FXIOS-10245 [Homepage rebuild] Remove legacy homepage #30388
+413
−10,189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💪 Quality guardian50 tests files modified. You're a champion of test coverage! 🚀 🧟♂️ Monster PRWow, this PR is huge with 10602 lines changed! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 🎉 BrowserViewController got smallerNice! 🧑💻 New
|
| File | Coverage | Required |
|---|---|---|
firefox-ios/Client/Frontend/Home/Homepage/HomepageUX.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift |
30.8% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Bookmark/BookmarksCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/ContextMenu/ContextMenuState.swift |
30.5% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/JumpBackIn/JumpBackInCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/JumpBackIn/SyncedTabCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Layout/HomepageLayoutMeasurementCache.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Layout/HomepageSectionLayoutProvider.swift |
19.7% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Layout/TopSitesSectionLayoutProvider.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Merino/MerinoStandardCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/MessageCard/HomepageMessageCardCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/SearchBar/SearchBarCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/DataManagement/Contile.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/DataManagement/ContileNetworking.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/DataManagement/GoogleTopSiteManager.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/DataManagement/TopSiteHistoryManager.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/EmptyTopSiteCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/TopSite.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/TopSites/TopSiteCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Interface/WallpaperManager.swift |
21.1% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Models/WallpaperCollectionType.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Models/WallpaperMetadata.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/NetworkServices/WallpaperImageLoader.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Protocols/WallpaperNetworking.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/UI/LegacyWallpaperBackgroundView.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/UI/WallpaperCellViewModel.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/UI/WallpaperCollectionViewCell.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/UI/WallpaperSelectorViewController.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Utilities/WallpaperMigrationUtility.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/Homepage/Wallpapers/v1/Utilities/WallpaperThumbnailUtility.swift |
0.0% | 35.0% |
firefox-ios/Client/Frontend/Home/UnifiedAds/UnifiedTile.swift |
0.0% | 35.0% |
Client.app: Coverage: 36.57
| File | Coverage | |
|---|---|---|
| MerinoManager.swift | 100.0% | ✅ |
| TopSitesAction.swift | 100.0% | ✅ |
| WallpaperCollectionAvailability.swift | 100.0% | ✅ |
| BrowserViewController.swift | 30.76% | |
| JumpBackInCell.swift | 0.0% | |
| Wallpaper.swift | 92.06% | ✅ |
| TopSitesSectionLayoutProvider.swift | 0.0% | |
| ContileProvider.swift | 90.91% | ✅ |
| FeatureFlagsDebugViewController.swift | 0.0% | |
| SearchBarCell.swift | 0.0% | |
| HeaderState.swift | 76.27% | ✅ |
| HomepageState.swift | 78.07% | ✅ |
| SectionHeaderConfiguration.swift | 100.0% | ✅ |
| MerinoState.swift | 96.39% | ✅ |
| BrowserCoordinator.swift | 68.12% | ✅ |
| HomepageTelemetry.swift | 98.28% | ✅ |
| HomePageSettingViewController.swift | 6.11% | |
| UnifiedAdsProvider.swift | 87.39% | ✅ |
| BookmarksSectionState.swift | 95.89% | ✅ |
| WallpaperAction.swift | 100.0% | ✅ |
| WallpaperState.swift | 98.0% | ✅ |
| WallpaperURLProvider.swift | 75.0% | ✅ |
| MerinoAction.swift | 100.0% | ✅ |
| LabelButtonHeaderView.swift | 66.67% | ✅ |
| SearchBarState.swift | 96.15% | ✅ |
| TopSiteCell.swift | 0.0% | |
| JumpBackInTabConfiguration.swift | 35.29% | |
| WallpaperFilePathProvider.swift | 81.4% | ✅ |
| LegacyWallpaperBackgroundView.swift | 0.0% | |
| HomepageViewController.swift | 50.46% | ✅ |
| ContileNetworking.swift | 0.0% | |
| WallpaperMigrationUtility.swift | 0.0% | |
| WallpaperSettingsViewModel.swift | 71.92% | ✅ |
| TopTabDisplayManager.swift | 14.89% | |
| WallpaperImageLoader.swift | 0.0% | |
| WallpaperSelectorViewModel.swift | 80.09% | ✅ |
| WallpaperMiddleware.swift | 95.0% | ✅ |
| GoogleTopSiteManager.swift | 0.0% | |
| WallpaperMetadataCodableProtocol.swift | 100.0% | ✅ |
| JumpBackInSectionState.swift | 94.74% | ✅ |
| WallpaperBackgroundView.swift | 94.55% | ✅ |
| EmptyTopSiteCell.swift | 0.0% | |
| WallpaperCollection.swift | 67.39% | ✅ |
| MerinoStoryConfiguration.swift | 95.65% | ✅ |
| WallpaperStorageUtility.swift | 41.86% | |
| ContentContainer.swift | 94.74% | ✅ |
| HomepageLayoutMeasurementCache.swift | 0.0% | |
| Tab.swift | 58.99% | ✅ |
| TopSiteConfiguration.swift | 50.0% | |
| MerinoMiddleware.swift | 100.0% | ✅ |
| SyncedTabCell.swift | 0.0% | |
| HomepageDiffableDataSource.swift | 81.2% | ✅ |
| HomepageHeroImageViewModel.swift | 100.0% | ✅ |
| MessageCardAction.swift | 100.0% | ✅ |
| MessageCardState.swift | 95.92% | ✅ |
| SponsoredTileDataUtility.swift | 100.0% | ✅ |
| WallpaperDataService.swift | 62.5% | ✅ |
| BookmarksCell.swift | 0.0% | |
| ContextMenuState.swift | 30.46% | |
| BookmarksMiddleware.swift | 89.16% | ✅ |
| ShortcutsLibraryViewController.swift | 62.75% | ✅ |
| TopSitesManager.swift | 98.03% | ✅ |
| ContextMenuConfiguration.swift | 100.0% | ✅ |
| WallpaperManager.swift | 21.05% | |
| StoryCell.swift | 80.79% | ✅ |
| HomepageSectionLayoutProvider.swift | 19.68% | |
| NimbusFlaggableFeature.swift | 95.48% | ✅ |
| WallpaperMetadataUtility.swift | 75.71% | ✅ |
| MerinoStandardCell.swift | 0.0% | |
| HomepageMessageCardCell.swift | 0.0% | |
| TopSitesSectionState.swift | 97.48% | ✅ |
| WallpaperSelectorViewController.swift | 0.0% | |
| CustomizeHomepageSectionCell.swift | 83.93% | ✅ |
| WallpaperMetadataLoader.swift | 100.0% | ✅ |
| WallpaperCollectionViewCell.swift | 0.0% | |
| ContextMenuAction.swift | 100.0% | ✅ |
| NimbusFeatureFlagLayer.swift | 77.2% | ✅ |
| TelemetryWrapper.swift | 65.5% | ✅ |
| HomepageDimensionImplementation.swift | 89.69% | ✅ |
| HomeLogoHeaderCell.swift | 90.2% | ✅ |
| UnifiedAdsCallbackTelemetry.swift | 80.52% | ✅ |
| WallpaperThumbnailUtility.swift | 0.0% | |
| Site+createSponsoredSite.swift | 100.0% | ✅ |
| WallpaperSettingsViewController.swift | 2.56% | |
| PrivateHomepageViewController.swift | 54.63% | ✅ |
| TopSiteHistoryManager.swift | 0.0% | |
| BookmarksAction.swift | 100.0% | ✅ |
| TopSite.swift | 0.0% | |
| WallpaperNetworkModule.swift | 100.0% | ✅ |
| UnifiedAdsConverter.swift | 100.0% | ✅ |
| ContextMenuCoordinator.swift | 100.0% | ✅ |
| TabCell.swift | 70.11% | ✅ |
| HomepageHeaderCell.swift | 91.3% | ✅ |
| BookmarkConfiguration.swift | 75.0% | ✅ |
| MessageCardMiddleware.swift | 100.0% | ✅ |
| JumpBackInAction.swift | 100.0% | ✅ |
| TabManagerImplementation.swift | 55.6% | ✅ |
| HomepageMiddleware.swift | 46.43% | |
| TopSitesMiddleware.swift | 86.86% | ✅ |
| HomepageAction.swift | 100.0% | ✅ |
| StoryProvider.swift | 100.0% | ✅ |
Generated by 🚫 Danger Swift against d90e8d1
lmarceau
commented
Nov 5, 2025
|
|
||
| refreshStore(shouldAnimate: true) | ||
|
|
||
| let notificationObject = [Tab.privateModeKey: isPrivate] |
There was a problem hiding this comment.
This is not needed anymore since the legacy homepage was the only one listening to this notification
|
This pull request has conflicts when rebasing. Could you fix it @lmarceau? 🙏 |
lmarceau
commented
Nov 5, 2025
|
|
||
| private let scrollView: UIScrollView = .build() | ||
|
|
||
| private var headerViewModel: HomepageHeaderCellViewModel { |
There was a problem hiding this comment.
Somehow that wasn't used anywhere, so removing it
lmarceau
commented
Nov 5, 2025
|
|
||
| selectTab(nextSelectedTab) | ||
|
|
||
| let notificationObject = [Tab.privateModeKey: nextSelectedTab?.isPrivate ?? true] |
There was a problem hiding this comment.
Same notification as above, this was only listened to in the legacy Homepage
lmarceau
commented
Nov 5, 2025
| notification_emails: | ||
| - [email protected] | ||
| expires: "2026-01-01" | ||
| recently_saved_bookmark_view: |
There was a problem hiding this comment.
@cyndichin I found the two following telemetry events were only used for the legacy homepage:
- recently_saved_bookmark_view
- firefox_homepage_origin
Just want to double-check this is expected
lmarceau
force-pushed
the
lm/remove-legacy-homepage
branch
from
919abc3 to
d866727
Compare
lmarceau
force-pushed
the
lm/remove-legacy-homepage
branch
from
d866727 to
535a6e3
Compare
|
This pull request has conflicts when rebasing. Could you fix it @lmarceau? 🙏 |
lmarceau
force-pushed
the
lm/remove-legacy-homepage
branch
from
535a6e3 to
c554459
Compare
|
Build was green! ✅ But since this changes homepage files I'll get conflicts often 😆 In the meantime:
|
lmarceau
force-pushed
the
lm/remove-legacy-homepage
branch
from
133ee33 to
d90e8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This is a big PR, but it's a fun one! It removes the legacy homepage and it's related code.
LegacyHomepageViewControllerand friends + the relatedhomepageRebuildFeaturefeature flagTelemetryWrapperevents,LegacyTopSitefeature flag (hntTopSitesVisualRefreshsince this is released in the wild with no experiments)Experiment to double-check
One extra thing I want to check before merging this in
main:homepage-rebuild-feature. The theory to me is that this has no effect sincehomepage-rebuild-featureis set totrueon both branches, and that flag is true in all channel. But I'll double check the experiment still works as expected if that flag isn't present anymore.📝 Checklist