Skip to content

BugFix [Onboarding] FXIOS-13905 Voice Over not working properly with scrolling on iPad #30399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
+18 −0
Merged

BugFix [Onboarding] FXIOS-13905 Voice Over not working properly with scrolling on iPad #30399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43368c4
Fix Voice Over scroll on iPad onboarding
Nov 5, 2025
f61ae41
lint
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions BrowserKit/Sources/OnboardingKit/Views/Regular/OnboardingViewRegular.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ struct OnboardingViewRegular<ViewModel: OnboardingCardInfoModelProtocol>: Themea
}
.cardBackground(theme: theme, cornerRadius: UX.CardView.cornerRadius)
}
.accessibilityScrollAction { edge in
Copy link
Collaborator

@razvanlitianu razvanlitianu Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, what gesture activates this method?

Copy link
Collaborator Author

@FilippoZazzeroni FilippoZazzeroni Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, this gesture stubs the default scroll gesture for the Voice over, giving us the ability to handle scroll ourself instead of using the default.

handleAccessibilityScroll(from: edge)
}
Button(action: viewModel.skipOnboarding) {
Text(viewModel.skipText)
.font(FXFontStyles.Bold.body.scaledSwiftUIFont(sizeCap: UX.Onboarding.Font.skipButtonSizeCap))
Expand Down Expand Up @@ -74,4 +77,19 @@ struct OnboardingViewRegular<ViewModel: OnboardingCardInfoModelProtocol>: Themea
)
.padding(.bottom)
}

private func handleAccessibilityScroll(from edge: Edge) {
if edge == .leading {
viewModel.scrollToPreviousPage()
} else if edge == .trailing {
viewModel.scrollToNextPage()
}
switch edge {
case .leading, .trailing:
DispatchQueue.main.async {
UIAccessibility.post(notification: .screenChanged, argument: nil)
}
default: break
}
}
}