Skip to content

Add FXIOS-14001 [Stories Feed] Shield icon states #30414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Add FXIOS-14001 [Stories Feed] Shield icon states #30414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions firefox-ios/Client/Frontend/StoriesFeed/StoriesWebviewViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ class StoriesWebviewViewController: UIViewController,
label.numberOfLines = 1
}

private let shieldImageView: UIImageView = .build { imageView in
imageView.image = UIImage(named: StandardImageIdentifiers.Large.shieldCheckmark)?.withRenderingMode(.alwaysTemplate)
}
private let shieldImageView: UIImageView = .build()

private lazy var reloadToolbarButton: UIBarButtonItem = {
let button = UIBarButtonItem(
Expand Down Expand Up @@ -164,6 +162,10 @@ class StoriesWebviewViewController: UIViewController,
func webView(_ webView: WKWebView, didFinish navigation: WKNavigation?) {
// Update domain label when navigation finishes (in the same window)
domainLabel.text = webView.url?.normalizedHost

shieldImageView.image = webView.hasOnlySecureContent ?
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: Could we enhance a bit readability here:

let image = if webView.hasSecureContent {
 UIImage.template
} else {
 UIImage(named: )
}

UIImage.templateImageNamed(StandardImageIdentifiers.Small.shieldCheckmarkFill)
: UIImage(named: StandardImageIdentifiers.Small.shieldSlashFillMulticolor)
}

// MARK: - WKUIDelegate
Expand All @@ -187,6 +189,6 @@ class StoriesWebviewViewController: UIViewController,
let theme = themeManager.getCurrentTheme(for: windowUUID)
applyNavigationBarTheme(theme: theme)
domainLabel.textColor = theme.colors.textPrimary
shieldImageView.tintColor = theme.colors.iconPrimary
shieldImageView.tintColor = theme.colors.iconSecondary
}
}