Skip to content

Conversation

@lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Nov 5, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Migrating toolbar classes to use dispatch instead of dispatchLegacy

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@lmarceau lmarceau requested a review from thatswinnie November 5, 2025 21:37
@lmarceau lmarceau requested a review from a team as a code owner November 5, 2025 21:37
})
}

// Laurie - This is never called?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thatswinnie Should we call this in deinit?

})
}

// Laurie - This is never called?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same @thatswinnie should we call this in deinit?

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 38.29%

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.06

File Coverage
NavigationToolbarContainerModel.swift 61.9%
NavigationToolbarContainer.swift 87.95%
AddressToolbarContainer.swift 41.94% ⚠️
BrowserViewController.swift 30.69% ⚠️
TabScrollHandler.swift 75.09%
AddressBarPanGestureHandler.swift 27.24% ⚠️
AddressToolbarContainerModel.swift 80.94%

ToolbarKit: Coverage: 62.78

File Coverage
LocationViewState.swift 100.0%
LocationView.swift 60.84%

Generated by 🚫 Danger Swift against cdc86e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants