Update APILintPlugin to make it configuration-cache friendly #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncalexan
reviewed
Mar 27, 2025
|
|
||
| def apiGenerate = project.task("apiGenerate${name}", type: ApiCompatLintTask) { | ||
| description = "Generates API file for build variant ${name}" | ||
| doFirst { |
There was a problem hiding this comment.
Does this need a doFirst at all? Could we make the classpath be a provider so it's lazy?
There was a problem hiding this comment.
I couldn't get it to run locally, so did the safest thing which I knew would work. But I am quite sure you are correct and we don't need doFirst, but will need to test it locally!
There was a problem hiding this comment.
Mmm, we should probably vendor this someday. Anyway, a project for a later day. If this works for you, roll on.
ncalexan
approved these changes
Mar 27, 2025
jonalmeida
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.