Skip to content

Conversation

@suvayu
Copy link

@suvayu suvayu commented Apr 29, 2025

Description

The glean parser script uses pkg_resources, and running the glean parser script fails.

According to the release notes for Python 3.121, setuptools is not included in a virtual environment by default any more and should be explicitly included.

I don't know what would be the appropriate version, the latest version worked for me. So I used that.

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Footnotes

  1. https://docs.python.org/3/whatsnew/3.12.html

The glean parser script uses `pkg_resources`, and according to the release notes for Python 3.12[^1], `setuptools` is not included in a virtual environment by default any more.  So include it here.  I don't know what would be the appropriate version, the latest version worked for me.  So I used that.

[^1]: https://docs.python.org/3/whatsnew/3.12.html
@strseb
Copy link
Collaborator

strseb commented Apr 30, 2025

Hey, Thanks for the PR. While i agree with the contents and the premise, i do think this is not the correct place to fix that. If glean has a dependency on that, it should list that.
So i suppose this should be added here: https://github.com/mozilla/glean_parser/blob/main/pyproject.toml
If this breaks your workflow and you don't want to hassle with yet another mozilla repo happy to pass the patch to the team, otherwise they are probably happy to get a pr for that.
Let me know what you think :)

@suvayu
Copy link
Author

suvayu commented May 1, 2025

Hi @strseb, thanks for the comment, agree with your analysis. I would be fine with it if you pass along this fix upstream. I only compile the VPN client since it's not packaged for Fedora.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants