Skip to content

Conversation

@mcleinman
Copy link
Collaborator

Description

This is built on top of #10738. Just a few small tweaks to make it build. Seems to test okay.

Reference

VPN-7148

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from strseb October 20, 2025 20:27
Copy link
Collaborator

@artfwo artfwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@firefoxci-taskcluster
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozillavpn-level-1/aPLukVOdRJmXSqx0z8Iopw/QY5mhSt2RzqC2M1phJY-2Q",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozillavpn-level-1/aPLukVOdRJmXSqx0z8Iopw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozillavpn-level-1/aPLukVOdRJmXSqx0z8Iopw/QY5mhSt2RzqC2M1phJY-2Q",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozillavpn-level-1/aPLukVOdRJmXSqx0z8Iopw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-10-21T13:56:40.390Z

@strseb
Copy link
Collaborator

strseb commented Oct 27, 2025

I think you need to also update robolectric in android/vpnClient/build.gradle - given it implements a testable version of the android api, so it fails as it probably does not support that api level.

@mcleinman mcleinman force-pushed the vpn-7148-update-new-android-api branch from 584b18d to b6c0d0f Compare October 29, 2025 21:36
@mcleinman mcleinman force-pushed the vpn-6766-android-qt-6.9 branch 2 times, most recently from 66098ce to 5a4f6ac Compare October 30, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants