Skip to content

Conversation

@mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Oct 27, 2025

Description

The range of libraries we include in our bundle required various fixes to support 16kb page sizes. Notably, we needed to upgrade Qt to 6.9.3 to do so.

I used Android Studio's APK Analyzer in this work. Ultimately, there are still two 4kb mentions in it:

  1. A metadata file shows "4kb" in the analyzer, though not with the full 4kb error initially shown for other libraries. Including it may not cause us to fail checks. However, if it does, we may be able to remove it with no side effects by adding this to build.gradle files:
        resources {
          excludes += [
            "META-INF/com.google.android.gms.play-services-tasks.properties",
            "META-INF/**/play-services-tasks.properties"
          ]
        }
  1. While there are no longer any libraries that show the APK does not support 16 KB devices warning, the overall enclosing folder still shows that warning. I have no idea why, and searching hasn't led to results. I'm wondering if this is an error? After this is merged, I want to upload an APK to test and see if Google Play accepts it.

Reference

VPN-6600

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from a team as a code owner October 27, 2025 21:42
@mcleinman mcleinman requested review from bhearsum and removed request for a team October 27, 2025 21:42
@mcleinman mcleinman marked this pull request as draft October 27, 2025 21:42
@mcleinman mcleinman changed the base branch from main to vpn-7148-update-new-android-api October 27, 2025 21:42
@bhearsum bhearsum removed their request for review October 29, 2025 18:09
@mcleinman mcleinman marked this pull request as ready for review October 29, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants