Skip to content

VPN-6293 - Maybe fix ip assignment c: #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

VPN-6293 - Maybe fix ip assignment c: #10854

wants to merge 2 commits into from

Conversation

@strseb
Copy link
Collaborator

@strseb strseb commented Nov 4, 2025 •
edited
Loading

Description

We see in the ticket the following logs during activation:

[18.09.2025 07:09:52.238] (WireguardUtilsWindows) Error: Failed to assign ivp6: CreateUnicastIpAddressEntry failed with error :  1168
[18.09.2025 07:09:52.238] (WireguardUtilsWindows) Error: Failed setIPv6AddressAndMask
[18.09.2025 07:09:52.238] (WireguardUtilsWindows) Error: Failure during Adapter Creation, Closing Device

1168 Means that the row matches an adapter that does not exist.

-> We set the ipv4 explicitly using it's interface index, so let's do that lookup once and use it for both addresses. This way we should assert before that it exists.
-> I also noticed the row was incorrectly setting it's address type, so maybe that trips it over?

@strseb strseb changed the title Basti/welp VPN-6293 - Maybe fix ip assignment c: Nov 4, 2025
@strseb strseb requested review from artfwo and mcleinman November 4, 2025 14:21
mcleinman
mcleinman approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/platforms/windows/daemon/wireguardutilswindows.cpp
/**
* @brief Assigns an ipv4 address to a network device with a given LUID
*
* @param luid - LUID of the Adapter
Copy link
Collaborator

@mcleinman mcleinman Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcleinman mcleinman mcleinman approved these changes

@artfwo artfwo Awaiting requested review from artfwo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strseb @mcleinman