Add a milestone CLOSED validator #229
Conversation
__main__.py
Outdated
| handle_bitrise_builds, | ||
| ) | ||
|
|
||
| """ |
There was a problem hiding this comment.
commenting this out for now only because its throwing an error locally
__main__.py
Outdated
| 'bugzilla-meta-bugs': handle_bugzilla_meta_bugs, | ||
| 'bugzilla-qe-verify': handle_bugzilla_qe_verify, | ||
| 'bugzilla-query-by-keyword': handle_bugzilla_query_by_keyword, | ||
| #'bugzilla-desktop-bugs': handle_bugzilla_desktop_bugs, |
api/testrail/report_milestones.py
Outdated
| pl.extract_build_version | ||
| ) | ||
|
|
||
| import sys |
|
|
||
|
|
||
| def handle_testrail_milestones_closed(args): | ||
| milestone_validate_closed = True |
There was a problem hiding this comment.
doing it this way, we don't have to make the COMMAND_MAP more complex with additional input params. We simply use a different function name and pass in an optional variable which will trigger an alternate path for the report module we already have in place for milestones
api/testrail/report_milestones.py
Outdated
| # =================================================================== | ||
|
|
||
| def report_milestones_insert(projects_id, payload): | ||
| def _db_upsert(projects_id, payload): |
There was a problem hiding this comment.
upsert is a stand name for an insert / update / upload operation.
| # =================================================================== | ||
|
|
||
| def testrail_milestones(project): | ||
| def run(project, milestone_validate_closed: bool = False): |
There was a problem hiding this comment.
There is only 1 entry point to this module (and all report modules). Standard practice in this case is to use an entry function called: run.
Other new standards here are using: _fetch for fetching external API data
and _upsert for remote update / upload / insert operations
| @@ -0,0 +1,88 @@ | |||
| name: Testops - TestRail Milestone CLOSED - polling | |||
There was a problem hiding this comment.
introducing a new workflow environment: demo for PRs
Once the PR has passed review, demo can change to either staging or production
Purpose
The purpose of this PR is to add a TestRail Milestone CLOSED trigger. i.e. When someone closes a Milestone, some follow on actions would be performed.
Follow-on Actions
Notes
ChatGPT