-
Notifications
You must be signed in to change notification settings - Fork 2
Add capability to query deployed commits 📦 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| if config.commitLimit > 250 { | ||
| return fmt.Errorf("commit-limit cannot be greater than 250") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for a 250 commit limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! At the time I've added that check, the internal REST API client didn't support pagination yet:
https://github.com/mozilla-services/rapid-release-model/pull/35/files#diff-7525bc78a0e3497bcd41a5862aed2f3e47732af92fe2e4be04f92132aecba748R12-R23
We can probably drop that upper limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! 😄
gdover9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks absolutely fantastic! Will do some testing shortly but I don't see any issues - thank you for working so much on this!
|
All looks good in terms of |
|
Have tested |
|
Thanks for the reviews, folks! 📦 🚀 |
This PR introduces the ability to retrieve all commits included in a given deployment, addressing a key requirement for accurately measuring
Lead Time for Changesin Four Keys.Key Changes
metricsCLI app as well as thegithubpackageRecommended review order
go.modandgo.sumfor newgithub.com/google/go-github/v68dependencypkg/github/rest/with new GitHub REST API codepkg/github/graphql/with updated GitHub GraphQL API codepkg/github/*.gowith higher-level GitHub API codepkg/github/internal/test/with test framework forpkg/githubmetrics/internal/factory/for refactored factory codemetrics/cmd/**/*.gometrics/Jira ticket
CICD-441
Issues
Resolve #19
Resolve #30
Resolve #33
Notes
Note: AI tools were used in generating this pull request 🤖