Closed
Conversation
jrconlin
reviewed
Jul 15, 2024
| [tool.poetry] | ||
| name = "syncstorage-rs" | ||
| version = "0.1.0" | ||
| description = "sync storage server in rust" |
Member
There was a problem hiding this comment.
There's a potential that folk might discover this package while looking for a stand-alone Sync storage server. Let's be exceptionally clear about what this is and how it's being used.
Suggested change
| description = "sync storage server in rust" | |
| description = "Support package for the Mozilla Sync storage server, written in rust. This is not a 'stand alone' server and is not meant for general use to run your own Sync storage server. Please see [the wiki page](https://github.com/mozilla-services/syncstorage-rs/wiki/overview) for further details." |
jrconlin
reviewed
Jul 15, 2024
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
b8c0ff2 to
2aa78e2
Compare
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
d7af2bd to
fa1df48
Compare
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
a3673b2 to
c20fcb1
Compare
jrconlin
reviewed
Sep 11, 2024
| ) | ||
| writer = DataFileWriter( | ||
| open(out_file_name, "wb"), DatumWriter(), schema) | ||
| for chunk in range(max(1, math.trunc(math.ceil(row_count / MAX_ROWS)))): |
Member
There was a problem hiding this comment.
Yeah, i'd have words with the folk behind black and why they want python to look like perl, but 🤷🏻
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
c20fcb1 to
8d649a8
Compare
Collaborator
Author
|
Thanks for the comments @jrconlin . I shelved this one before MozWeek, but I don't think it hurts to merge in now, we can pick up the steps later once we've finished our priority tasks. All the parts are there to utilize the tooling with some format improvements, we'll just make the move to Poetry (officially, should we wish) down the road. |
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
57c08e2 to
3bd2a93
Compare
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
3bd2a93 to
d2ff740
Compare
… matching between subdirectories
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
d2ff740 to
217b226
Compare
Collaborator
Author
|
Superseded by #1706 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to Poetry for Python dependency management.
This puts all the tools, dependencies, and commands in place. However, we won't spin our wheels right now converting over in CI, moving from venv and whatnot, since we're not prioritizing Sync modernization atm. We will address down the road, but for the time being increases developer speed and experience for checks and makes some improvements to the python utilities.
Benefits:
Testing
How should reviewers test?
Issue(s)
Closes 4293.