Fix up some internal dependences.#6412
Merged
mhammond merged 1 commit intomozilla:mainfrom Oct 10, 2024
Merged
Conversation
Takes the easy bits of mozilla#6129
ba0febb to
8e162f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
+ Coverage 49.30% 52.74% +3.43%
==========================================
Files 146 125 -21
Lines 13708 12815 -893
==========================================
Hits 6759 6759
+ Misses 6949 6056 -893 ☔ View full report in Codecov by Sentry. |
mhammond
commented
Oct 9, 2024
| /// A dummy symbol we include so that we can detect whether or not the reqwest | ||
| /// backend got compiled in. | ||
| #[no_mangle] | ||
| pub extern "C" fn viaduct_detect_reqwest_backend() { |
Member
Author
There was a problem hiding this comment.
this was from Tarik - @bendk, do you know whether this is actually safe to remove when considering desktop?
Contributor
There was a problem hiding this comment.
I think so? I don't see that when I search in searchfox.
Member
Author
There was a problem hiding this comment.
Thanks - I hope you mean does look safe to remove, so I'll mark this as ready
Contributor
linabutler
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the easy bits of #6129
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.