Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some internal dependences. #6412

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

mhammond
Copy link
Member

@mhammond mhammond commented Oct 9, 2024

Takes the easy bits of #6129

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (bfe363c) to head (8e162f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6412      +/-   ##
==========================================
+ Coverage   49.30%   52.74%   +3.43%     
==========================================
  Files         146      125      -21     
  Lines       13708    12815     -893     
==========================================
  Hits         6759     6759              
+ Misses       6949     6056     -893     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/// A dummy symbol we include so that we can detect whether or not the reqwest
/// backend got compiled in.
#[no_mangle]
pub extern "C" fn viaduct_detect_reqwest_backend() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was from Tarik - @bendk, do you know whether this is actually safe to remove when considering desktop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? I don't see that when I search in searchfox.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I hope you mean does look safe to remove, so I'll mark this as ready

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went spelunking, and it looks like Thom added this way back in #937, as a check to ensure that we never included the Reqwest backend in our (then-Android only) Megazords—and which Ed removed in #3191.

@mhammond mhammond marked this pull request as ready for review October 9, 2024 21:08
@mhammond mhammond added this pull request to the merge queue Oct 10, 2024
Merged via the queue into mozilla:main with commit 3ba1c7c Oct 10, 2024
17 checks passed
@mhammond mhammond deleted the push-qrursssuktts branch October 10, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants