-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up some internal dependences. #6412
Conversation
Takes the easy bits of mozilla#6129
ba0febb
to
8e162f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
+ Coverage 49.30% 52.74% +3.43%
==========================================
Files 146 125 -21
Lines 13708 12815 -893
==========================================
Hits 6759 6759
+ Misses 6949 6056 -893 ☔ View full report in Codecov by Sentry. |
/// A dummy symbol we include so that we can detect whether or not the reqwest | ||
/// backend got compiled in. | ||
#[no_mangle] | ||
pub extern "C" fn viaduct_detect_reqwest_backend() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was from Tarik - @bendk, do you know whether this is actually safe to remove when considering desktop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? I don't see that when I search in searchfox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I hope you mean does look safe to remove, so I'll mark this as ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Takes the easy bits of #6129
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.