Skip to content

Conversation

@cyndichin
Copy link

@cyndichin cyndichin commented Nov 24, 2025

Pull Request checklist

This patch adds a new method metadata_delete_search_terms that deletes the entries in the moz_places_metadata_search_queries table. This is to support a new feature in which we want to delete the search terms stored instead of deleting the entire history metadata.

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@cyndichin cyndichin force-pushed the feat/add-delete-search-terms-method-in-history-metadata branch from c65cb6c to 14d3dd1 Compare November 24, 2025 18:50
@cyndichin cyndichin force-pushed the feat/add-delete-search-terms-method-in-history-metadata branch from 14d3dd1 to 7f046cf Compare November 24, 2025 18:55
@cyndichin cyndichin marked this pull request as ready for review November 24, 2025 18:56
@cyndichin
Copy link
Author

@mhammond This is my first Rust PR, so let me know if there is anything that I missed! We want to add a new method to only delete search term entries and not all of the history metadata entries. This is because we want to allow users to clear / delete their recent search terms without needing to impact other entries.

thanks to @issammani for helping me along the way.

@cyndichin cyndichin changed the title Add convenience metadata_delete_search_terms method to delete search terms in history metadata Add metadata_delete_search_terms method to delete search terms in history metadata Nov 24, 2025
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants