Remove all Contentful-related code from the project #15845
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexgibson Over to you for a scan over. If you're happy let's push to to the integration tests branch to get an early heads-up on any issues. Hopefully we'll have the VPN RC pages all published in all locales late next week, then we can merge this |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15845 +/- ##
==========================================
+ Coverage 79.28% 79.70% +0.41%
==========================================
Files 159 152 -7
Lines 8343 7436 -907
==========================================
- Hits 6615 5927 -688
+ Misses 1728 1509 -219 ☔ View full report in Codecov by Sentry. |
* Drops the contentful app: views, models and templates * Drops Contentful-related settings * Drop static bundles that appeared to be for Contentful components only * Updates DB export script to not dump the contentful table * Does NOT do anything to automatically drop the contentful_ DB tables, however * Remove use of prefer_cms decorator for VPN RC views and moves the routing to cms_only_urls so that we can still reverse those page addresses * Move legacy /more/ redirects related to the VPN pages to global redirects (losing the locale-availability check, but deferring it to the CMS to 404 or not instead)
stevejalim
force-pushed
the
15843-remove-contentful
branch
from
2ca808c to
2d4fe74
Compare
Co-authored-by: Alex Gibson <[email protected]>
|
@stevejalim What's the status of this? It'd be good to merge the simplification. Also, it needs a rebase ;) |
|
Note: this is blocked on deciding what to do with the VPN pages with translations that existed in Contenful but do not yet have translations in Wagtail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL THE VPN RC PAGES HAVE BEEN PUBLISHED IN ALL 10 LANGUAGES FROM THE NEW CMS. See #15846
This changeset removes Contentful-related code from our codebase.
Issue / Bugzilla link
Resolves #15843
Depends on #15846