MNTOR-3378 - Data broker manual removal #5287

codemist · 2024-11-04T18:36:43Z

References:

Jira: MNTOR-3378
Figma: https://www.figma.com/design/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?node-id=3809-6501&t=EniBV7WqvPVnuivk-4

Path: /user/dashboard/fix/data-broker-profiles/removal-under-maintenance

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

Localization strings (if needed) have been added.
Commits in this PR are minimal and have descriptive commit messages.
I've added or updated the relevant sections in readme and/or code comments
I've added a unit test to test for potential regressions of this bug.
If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
All acceptance criteria are met.
Jira ticket has been updated (if needed) to match changes made during the development process.
Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

github-actions · 2024-11-04T18:53:04Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

codemist · 2024-11-04T19:20:09Z

src/app/functions/universal/scanResult.ts

+  | "removed"
+  | "removal_under_maintenance";


@rhelmer I believe this would be our first time consuming this endpoint for the manual data broker removal feature.

github-actions · 2024-11-04T19:23:10Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-04T19:36:37Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-06T21:02:42Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T19:01:56Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T19:58:56Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T20:08:31Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T20:15:37Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T20:48:03Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T22:05:51Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

locales/en/exposure-card.ftl

locales-pending/dashboard-premium.ftl

flozia

This is looking good so far! There are some open comments and questions I’m having:

Before landing any parts of this feature we’ll need to make sure to guard it behind a feature flag.
Additionally, we would need to add telemetry (potentially in a follow-up) to the CTAs to fulfill the acceptance criteria.
For smaller viewports it might be better to stack the buttons:

locales-pending/dashboard-premium.ftl

src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/View.tsx

flozia · 2024-11-13T10:48:41Z

...dashboard/fix/data-broker-profiles/removal-under-maintenance/RemovalUnderMaintenanceView.tsx

+        <div className={styles.removalContentSection}>
+          <dt>
+            {l10n.getString(
+              "data-broker-removal-maintenance-steps-to-remove-header",


This header would need to be:

Suggested change

"data-broker-removal-maintenance-steps-to-remove-header",

"data-broker-removal-maintenance-rationale-header",

flozia · 2024-11-13T10:57:31Z

...dashboard/fix/data-broker-profiles/removal-under-maintenance/RemovalUnderMaintenanceView.tsx

+      data={props.stepDeterminationData}
+      hideProgressIndicator={detailedRemovalGuide}
+    >
+      {!detailedRemovalGuide ? dataBrokerInformation : removalGuideInstructions}


The only way to go back to the exposures when the “removal instructions” are open is by clicking “Back to exposures” (which for many viewport sizes is out of sight). I’m wondering if it would not be more intuitive to follow our existing pattern of showing explainers in dialogs. If that was already decided against by UX and/or is out of scope we should at least make sure that the closing “x” button does not link back to the dashboard.

flozia · 2024-11-13T10:58:56Z

src/app/components/client/exposure_card/ExposureCard.test.tsx

@@ -85,6 +86,21 @@ describe("ScanResultCard", () => {
    expect(innerDescription).toBeInTheDocument();
  });

+  // Data broker removal under maintenance
+  it("shows the right description for a scan result card where removal is under maintenance", () => {


Nit: Should we also add a test that checks that the description is not shown for other statuses?

github-actions · 2024-11-13T19:39:43Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-13T19:43:11Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-13T19:45:21Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-13T20:57:07Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-13T21:31:24Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

Co-authored-by: Francesco Lodolo <[email protected]>

github-actions · 2024-11-14T20:45:20Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

codemist added 3 commits November 4, 2024 11:28

fix ui

dec0aa7

apply ui changes tto scanresultcard

1bd3c2d

apply styling to button

1ab2f5d

add removal under maintenance status

a22d17f

codemist commented Nov 4, 2024

View reviewed changes

codemist requested a review from rhelmer November 4, 2024 19:20

change cta label and write test

e7d8016

codemist added 2 commits November 4, 2024 14:53

add new removal under maintenance page

98a5cd4

test exposure card in new view data broker page

2552e73

codemist added 9 commits November 6, 2024 20:18

change terminology ot data broker

27635ae

make new scan result component for resolution flow

b0e33d2

ui fixes

fc50d36

add header

517feb7

add header string

dc27aa7

add box shadow

24cb2c7

add estimated time of removal

9f47831

add removal instructions view

23439bd

ui tweaks

b9a31d3

codemist marked this pull request as ready for review November 12, 2024 18:53

codemist requested a review from flodolo as a code owner November 12, 2024 18:53

codemist added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Nov 12, 2024

codemist added 2 commits November 12, 2024 13:55

rremove ispremium force

7e39450

remove commented out code

b8c87c0

codemist force-pushed the mntor-3378 branch from 8ff9086 to b8c87c0 Compare November 12, 2024 18:55

codemist requested a review from flozia November 12, 2024 18:56

fix tests

dc69fb9

add strings

d052179

revert back to info for sale

38b080d

fix deprecated strings

a2f42ed

move cta button to the bottom on mobile

6c06f12

flodolo reviewed Nov 13, 2024

View reviewed changes

locales/en/exposure-card.ftl Outdated Show resolved Hide resolved

locales-pending/dashboard-premium.ftl Outdated Show resolved Hide resolved

flozia reviewed Nov 13, 2024

View reviewed changes

codemist added 3 commits November 13, 2024 14:33

fix ftl

a55ea7d

fix string changes

6af38e2

ftl lint

4d4b27a

add condition to remove navclose from fixview

fd0e94f

add back arrow

58e3fbf

Update locales-pending/dashboard-premium.ftl

06da548

Co-authored-by: Francesco Lodolo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNTOR-3378 - Data broker manual removal #5287

MNTOR-3378 - Data broker manual removal #5287

codemist commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024

codemist Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

flozia left a comment

flozia Nov 13, 2024

flozia Nov 13, 2024

flozia Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

	"data-broker-removal-maintenance-steps-to-remove-header",
	"data-broker-removal-maintenance-rationale-header",

MNTOR-3378 - Data broker manual removal #5287

Are you sure you want to change the base?

MNTOR-3378 - Data broker manual removal #5287

Conversation

codemist commented Nov 4, 2024 • edited Loading

References:

Description

Screenshot (if applicable)

How to test

Checklist (Definition of Done)

github-actions bot commented Nov 4, 2024

codemist Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

flozia left a comment

Choose a reason for hiding this comment

flozia Nov 13, 2024

Choose a reason for hiding this comment

flozia Nov 13, 2024

Choose a reason for hiding this comment

flozia Nov 13, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

codemist commented Nov 4, 2024 •

edited

Loading