should we update the payments demo with main/minor other fixes #15618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(fxa-settings): Fix l10n and a11y of confirm password input
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1335.0 to 2.1397.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](aws/aws-sdk-js@v2.1335.0...v2.1397.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…k-2.1397.0 chore(deps): bump aws-sdk from 2.1335.0 to 2.1397.0
Because: * We need a way to bulk cancel subscriptions to a given plan This commit: * Creates a script that can cancel subscriptions to a given plan * with a few configuration options Closes FXA-7124
feat(auth): cancel subscriptions to plan script
fix(third-party-auth): Don't show Google/Apple login buttons in the Sync flow
fix(ipad): Reduce avatar size on mobileLandscape for iPad web view modal
Because: * Credit card names are brands and have to follow proper capitalization and formatting as per their individual guidelines. This commit: * Corrects credit card capitalization and formatting in paymentProvider mjml partial. * Corrects all references to "Mastercard" from "MasterCard" as that is the official branding. * Adds additional translations for card name instead of type and unknown card. * Updates applicable stories and tests. Closes FXA-7134
Because: * the invoice/preview endpoint is failing more often causing issues for users This commit: * adds some logging around the handler * removes some env checks so that response validation errors are logged in production Closes #FXA-7664
Because: * We are aiming to launch VPN in 16 new countries in Europe. This commit: * Adds additional currencies to supportedPayPalCurrencies. Closes FXA-7606
fix(l10n): Clarify recovery key hint explanation for l10n
feat(payments): update supported PayPal currencies list
fix(auth): add Logging To Invoice Previw Endpoint
Bumps [chalk](https://github.com/chalk/chalk) from 5.1.2 to 5.2.0. - [Release notes](https://github.com/chalk/chalk/releases) - [Commits](chalk/chalk@v5.1.2...v5.2.0) --- updated-dependencies: - dependency-name: chalk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
test(functional): Convert Robots test, oauth webchannel tests
fix(ip): Set x-forwarded-for header from gql to auth-server
fix(text): Don't display `Step 1 of 2` when deleting account with no password set
Because: * Localized plain text file is not rendering as expected on Android and Windows. * Hidden directionality characters get copied with key, resulting in the key being marked as invalid during password reset. * Reversal is temporary to prevent this issue from blocking deployment while next steps are determined. This commit: * Serve key only in the file download. * Add an optional query param to test downloading a detailed file 1) with BOM (byte-order-mark), 2) with charset defined, or 3) with TextEncoder * Add stories to download the 3 test options Closes #FXA-7688
Because: * Controlled components that used useWatch to obtain the current input value would reset to default (empty string) on submit or rerender * We want to ensure that if the submit aborts due to an error or if the page rerenders, controlled components will display the current input value and not an string. This commit: * Use getValues to set the default input value for useWatch in both places where it is used in the codebase (FlowRecoveryKeyHint and ResetPassword) Closes #FXA-7547
Because: * The lightbulb image in account recovery key creation step 4 was mispositioned on mobile * The focus outline was misplaced on the back button This commit: * Update sizing, rename and minify lightbulb svg * Adjust styling for back button * Remove background fill for security shield graphic Closes #FXA-7542, #FXA-7553
task(fxa-settings): Revert localized content in key download file
fix(fxa-settings): Ensure useWatch uses current input value as default
fix(fxa-settings): Various UI tweaks related to recovery key
test(functional): rewrite sync v3 settings test
Because: * we do not want to be inundated with request validation errors that are outside of our control This commit: * updates the reporting logic to only report response validation errors for all environments Closes #FXA-7664
…ors-only fix(auth): only Report Response Validation Errors
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 3.7.1 to 3.12.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v3.7.1...v3.12.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…t-16.5.5 chore(deps-dev): bump @nx/jest from 16.3.1 to 16.5.5
…ook/addon-actions-7.1.1 chore(deps-dev): bump @storybook/addon-actions from 7.0.26 to 7.1.1
…rser2-9.0.0 chore(deps-dev): bump htmlparser2 from 8.0.1 to 9.0.0
…-object-for-account-in-fxa-ac feat: add foundational db classes
…othing when clicked
fix(payments): Manage button from Subscription management page does nothing when clicked
Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) from 7.0.26 to 7.1.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v7.1.1/code/addons/essentials) --- updated-dependencies: - dependency-name: "@storybook/addon-essentials" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@opentelemetry/exporter-jaeger](https://github.com/open-telemetry/opentelemetry-js) from 1.13.0 to 1.15.1. - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.13.0...v1.15.1) --- updated-dependencies: - dependency-name: "@opentelemetry/exporter-jaeger" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react) from 7.0.26 to 7.1.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v7.1.1/code/renderers/react) --- updated-dependencies: - dependency-name: "@storybook/react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tsconfig-paths](https://github.com/dividab/tsconfig-paths) from 4.1.0 to 4.2.0. - [Changelog](https://github.com/dividab/tsconfig-paths/blob/master/CHANGELOG.md) - [Commits](dividab/tsconfig-paths@v4.1.0...v4.2.0) --- updated-dependencies: - dependency-name: tsconfig-paths dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ook/react-7.1.1 chore(deps-dev): bump @storybook/react from 7.0.26 to 7.1.1
…ook/addon-essentials-7.1.1 chore(deps-dev): bump @storybook/addon-essentials from 7.0.26 to 7.1.1
…ig-paths-4.2.0 chore(deps-dev): bump tsconfig-paths from 4.1.0 to 4.2.0
…lemetry/exporter-jaeger-1.15.1 chore(deps): bump @opentelemetry/exporter-jaeger from 1.13.0 to 1.15.1
Bumps [@opentelemetry/instrumentation-document-load](https://github.com/open-telemetry/opentelemetry-js-contrib) from 0.31.1 to 0.33.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-js-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js-contrib@instrumentation-pg-v0.31.1...host-metrics-v0.33.0) --- updated-dependencies: - dependency-name: "@opentelemetry/instrumentation-document-load" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…lemetry/instrumentation-document-load-0.33.0 chore(deps): bump @opentelemetry/instrumentation-document-load from 0.31.1 to 0.33.0
fix(settings): Remove label duplicated in InputText title attribute
feat(metrics): add view event for login confirmation code view
…bmit-event feat(metrics): add Glean event for login confirmation submit attempt
bcolsson
requested changes
Jul 31, 2023
|
@IvoJP should we add the Do Not Merge label here? |
|
This pull request issue has been marked as stale due to inactivity. It will be closed in a week if it continues to be stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.