task(settings,react): Add feature flag component that supports list of oauth client ids#15637
task(settings,react): Add feature flag component that supports list of oauth client ids#15637
Conversation
…f oauth client ids Because: - We want to feature flag certain features for certain oauth clients - We want to be able to wrap this component around a view to feature flag it This Commit: - Adds config `oauth.reactClientIdsEnabled` to flag oauth client that - Adds oauth client feature flag component to settings, which uses the config setting above and a 'wrapper' pattern. - Adds a general feature flag wrapper component to fxa-react.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 099343f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
|
Approved since the code looks fine. But it's not immediately obvious where the component gets teh client id for the |
@chenba I guess this was left open ended on purpose, and I think it should be up to the calling code. I am under the impression that we are trying not to access hooks (or url params) directly in the components themselves. This keeps them functionally pure. It's my understanding, that resolving something like client id will be a responsibility of the page, or in the future a responsibility of the page's 'container' once that pattern is place. |
Because
This pull request
oauth.reactClientIdsEnabledto flag oauth client thatIssue that this pull request solves
Closes: FXA-7126
Checklist
Put an
xin the boxes that apply