chore(test perf): log the duration of auth test server start/stop #17670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dschom opened as a draft with some simple console.logs to see there are noticeable patterns. Did you want to actually merge something into main or was your plan to cherry-pick onto the Sentry changes to get some perf numbers and close this without merging? Locally the first test suite took longer than the rest to to start. After two runs in CI, looks like the first and last test suite took longer to start and stop. And there's another suite that I have yet to identify that took longer than others to stop. I using auth-server's Here's how long the starts were on the initial CI integration test run: stops |
Because: - Sentry 8 is the latest version This commit: - deletes some integration code since Sentry does it automatically - updates code to use the Sentry 8 API - updates a few proxyquire calls because they were cause module not found errors in CI
chenba
force-pushed
the
FXA-10453-test-server-perf
branch
from
b36b62f
to
4fdf5b5
Compare
|
For Sentry 8 I first cherry-picked onto commit 83dc649, here are the results from that CI run starts stops |
|
@dschom the test server does take longer to start with the Sentry 8 changes. But I think you mentioned that it got progressively slower, which I'm not seeing. (Unless you meant the tests got progressively slower and not the server starts?) |
I was seeing that the last test was taking much longer that others to start and this was causing timeout failures. If used the word progressively, I misspoke. What's probably good news is that we definitely see a big jump due to sentry 8. For now, perhaps increase timeouts on the first and last test suite, is a minimal change to get this landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.