Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(auth, content): Remove feature flags for reset password with code #17672

Merged
merged 1 commit into from
Sep 25, 2024
Merged

cleanup(auth, content): Remove feature flags for reset password with code #17672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/functional-tests/tests/key-stretching-v2/recoveryKey.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ test.describe('severity-2 #smoke', () => {
page,
target,
pages: {
configPage,
signin,
signup,
settings,
Expand All @@ -69,11 +68,6 @@ test.describe('severity-2 #smoke', () => {
},
testAccountTracker,
}) => {
const config = await configPage.getConfig();
test.skip(
config.featureFlags.resetPasswordWithCode !== true,
'TODO in FXA-9728, remove this config check'
);
const { email, password } = testAccountTracker.generateAccountDetails();
await page.goto(
`${target.contentServerUrl}/?forceExperiment=generalizedReactApp&forceExperimentGroup=react&${signupVersion.query}`
Expand Down
147 changes: 0 additions & 147 deletions packages/functional-tests/tests/key-stretching-v2/recoveryKeyWithLink.spec.ts
View file
Open in desktop

This file was deleted.

14 changes: 1 addition & 13 deletions packages/functional-tests/tests/key-stretching-v2/resetPassword.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,9 @@ test.describe('severity-2 #smoke', () => {
test(`signs up as v${signupVersion.version} resets password as v${resetVersion.version} and signs in as v${signinVersion.version}`, async ({
page,
target,
pages: {
configPage,
signin,
signup,
settings,
resetPassword,
confirmSignupCode,
},
pages: { signin, signup, settings, resetPassword, confirmSignupCode },
testAccountTracker,
}) => {
const config = await configPage.getConfig();
test.skip(
config.featureFlags.resetPasswordWithCode !== true,
'TODO in FXA-9728, remove this config check'
);
const { email, password } = testAccountTracker.generateAccountDetails();
await page.goto(
`${target.contentServerUrl}/?forceExperiment=generalizedReactApp&forceExperimentGroup=react&${signupVersion.query}`
Expand Down
136 changes: 0 additions & 136 deletions packages/functional-tests/tests/key-stretching-v2/resetPasswordWithLink.spec.ts
View file
Open in desktop

This file was deleted.

14 changes: 3 additions & 11 deletions ...sswordWithCode/oauthResetPassword.spec.ts → .../resetPassword/oauthResetPassword.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,12 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import { getCode } from 'fxa-settings/src/lib/totp';
import { expect, test } from '../../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../../pages/resetPassword';
import { SigninPage } from '../../../pages/signin';
import { expect, test } from '../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../pages/resetPassword';
import { SigninPage } from '../../pages/signin';

test.describe('severity-1 #smoke', () => {
test.describe('oauth reset password', () => {
test.beforeEach(async ({ pages: { configPage } }) => {
const config = await configPage.getConfig();
test.skip(
config.featureFlags.resetPasswordWithCode !== true,
'see FXA-9728, remove conditional skip when feature flag removed'
);
});

test('reset password', async ({
target,
page,
Expand Down
14 changes: 3 additions & 11 deletions ...ode/oauthResetPasswordRecoveryKey.spec.ts → ...ord/oauthResetPasswordRecoveryKey.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,12 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import { expect, test } from '../../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../../pages/resetPassword';
import { SigninPage } from '../../../pages/signin';
import { expect, test } from '../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../pages/resetPassword';
import { SigninPage } from '../../pages/signin';

test.describe('severity-1 #smoke', () => {
test.describe('oauth reset password with recovery key', () => {
test.beforeEach(async ({ pages: { configPage } }) => {
const config = await configPage.getConfig();
test.skip(
config.featureFlags.resetPasswordWithCode !== true,
'see FXA-9728, remove conditional skip when feature flag removed'
);
});

test('reset password with account recovery key', async ({
target,
pages: { page, recoveryKey, relier, resetPassword, settings, signin },
Expand Down
14 changes: 3 additions & 11 deletions ...hCode/oauthResetPasswordScopeKeys.spec.ts → ...sword/oauthResetPasswordScopeKeys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,12 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import { expect, test } from '../../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../../pages/resetPassword';
import { SigninPage } from '../../../pages/signin';
import { expect, test } from '../../lib/fixtures/standard';
import { ResetPasswordPage } from '../../pages/resetPassword';
import { SigninPage } from '../../pages/signin';

test.describe('severity-1 #smoke', () => {
test.describe('oauth reset password scoped keys react', () => {
test.beforeEach(async ({ pages: { configPage } }) => {
const config = await configPage.getConfig();
test.skip(
config.featureFlags.resetPasswordWithCode !== true,
'see FXA-9728, remove conditional skip when feature flag removed'
);
});

test('reset password scoped keys', async ({
target,
page,
Expand Down
Loading