fix(scripts): improve inactive account uids script #17951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Nov 4, 2024
| @@ -161,19 +159,25 @@ const init = async () => { | |||
| ]) | |||
| .as('securityEventUids'); | |||
|
|
|||
| const accountCustomerUids = AccountCustomers.query() | |||
| .distinct('uid') | |||
There was a problem hiding this comment.
Are there non-distinct uids?
There was a problem hiding this comment.
No, I just got copy-paste happy. Thank you for catching that.
dschom
reviewed
Nov 5, 2024
| @@ -231,6 +230,8 @@ const init = async () => { | |||
| return 0; | |||
| } | |||
|
|
|||
| const fd = fs.openSync(filepath, 'a'); | |||
There was a problem hiding this comment.
node:fs/promises supports async/await for file io, not that it really matters here.
Because: - there were a few small issues with the inactive account uids script This commit: - stops opening an output file in dry run mode - fixes an import so that the tsc'd js won't error - eliminates the accounts with Stripe subscriptions in the initial query
chenba
force-pushed
the
FXA-10610-little-things
branch
from
0b70ccc
to
914222a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: