style(settings): General style updates #18020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpomerleau
force-pushed
the
FXA-10613
branch
3 times, most recently
from
99b0f3c
to
d69e5dd
Compare
Because: * Switching design to text-start default instead of text-center * Some images were cut off on mobile This commit: * Update style for AppLayout * Update image styling * Various tweaks to accomodate change to text-start * Set size for Mozilla logo in Storybook sidebar * Replace placeholder image used in storybooks * Increase spacing below primary buttons Closes #FXA-10613
vpomerleau
force-pushed
the
FXA-10613
branch
from
d69e5dd
to
50b350f
Compare
vbudhram
approved these changes
Nov 15, 2024
LZoog
approved these changes
Nov 15, 2024
| .card { | ||
| @apply card-base text-center; | ||
| @apply relative w-full border border-transparent mobileLandscape:w-120 mobileLandscape:bg-white rounded-xl px-8 py-9 mobileLandscape:shadow-card-grey-drop mb-6; |
| @@ -25,9 +25,10 @@ export const MOCK_AUTHPW = | |||
| 'b5a61d1f7a6b1b762539bd85f783b65f635def1025c3f66fc51a438a68a77d6d'; | |||
| export const MOCK_UNBLOCK_CODE = 'A1B2C3D4'; | |||
| export const MOCK_RECOVERY_CODE = 'a1b2c3d4e5'; | |||
| export const PLACEHOLDER_IMAGE_URL = 'https://loremflickr.com/512/512'; | |||
There was a problem hiding this comment.
placekitten no longer works 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-10613, FXA-10741
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Start align and image fix on mobile:
Signin (with start text align) - opted to leave email centered with avatar
Signup (sync) with text-start
Other information (Optional)
Opted to keep content centered on a few select screens:
Legal:
Confirmation pages that only contained a heading, centered image and one-liner text or CTA. E.g.,