Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): add email, google, apple sign in #18021

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

StaberindeZA
Copy link
Contributor

Because

  • On the checkout page, after populating the email clicking continue should navigate the user to the FxA signin page for signin.
  • On the checkout page, when clicking Google/Apple button, it should start the third party auth via FxA.
  • Completion of either signin option should navigate the user back to the checkout page in a signed in state.

This pull request

  • Updated Auth.js provider to support email, google and apple login
  • Customers are redirected to the '/new' page on successful login, which creates a new cart with the customers uid added.
  • Updates Payments Next auth config to a non-public client.

Issue that this pull request solves

Closes: #FXA-10548

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Any other information that is important to this pull request.

@StaberindeZA StaberindeZA requested a review from a team as a code owner November 14, 2024 20:25
Because:

- On the checkout page, after populating the email clicking continue
  should navigate the user to the FxA signin page for signin.
- On the checkout page, when clicking Google/Apple button, it should
  start the third party auth via FxA.
- Completion of either signin option should navigate the user back to
  the checkout page in a signed in state.

This commit:

- Updated Auth.js provider to support email, google and apple login
- Customers are redirected to the '/new' page on successful login, which
  creates a new cart with the customers uid added.
- Updates Payments Next auth config to a non-public client.

Closes #FXA-10548
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to start the stack and sign in with Google as well as create a Mozilla account - aligned with testing signing in with Apple on stage.

r+, thanks Reino!

@StaberindeZA StaberindeZA merged commit 09096fb into main Nov 15, 2024
25 checks passed
@StaberindeZA StaberindeZA deleted the fxa-10548-checkout-signinup branch November 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants