Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(recovery-phone): Add confirmCode method #18022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

task(recovery-phone): Add confirmCode method #18022

wants to merge 1 commit into from
+94 −1

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Nov 14, 2024

Because

  • We want to able to confirm a user's setup code

This pull request

  • Adds a method called confirmCode to the recovery-phone service
  • Register the phone number to the account in the event the code provided is valid.

Issue that this pull request solves

Closes: FXA-10348

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom
task(recovery-phone): Add confirmCode method
22692ae 
Because:
- We want to able to confirm a user's setup code

This Commit:
- Adds a method called confirmCode to the recovery-phone service
- Register the phone number to the account in the event the code provided is valid.
@dschom dschom requested a review from a team as a code owner November 14, 2024 22:03
@dschom dschom requested a review from vbudhram November 14, 2024 22:03
vbudhram
vbudhram approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbudhram vbudhram vbudhram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschom @vbudhram