fix(feat): Prototype Pollution Vulnerability in Mozilla FxA Account Management #18820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fxa/packages/fxa-settings/src/models/Account.ts
Line 1359 in 523ccc8
fix the issue need to prevent prototype pollution by ensuring that user-controlled keys cannot include dangerous values like
__proto__
,constructor
, orprototype
. This can be achieved by validating or sanitizing the keys before they are used in theaccounts
object. Specifically:currentAccount()
function inpackages/fxa-settings/src/lib/cache.ts
to validate theforceUid
andaccount.uid
keys before using them.References
Object.prototype.proto
Map
CWE-78
CWE-79
CWE-94
CWE-400
CWE-471
CWE-915
Checklist
Put an
x
in the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.