fix(payments-next): Update Checkout and Upgrade pages to reflect correct amount due #19075
+570
−395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlisachan
force-pushed
the
FXA-11929
branch
4 times, most recently
from
a6b5467 to
fec3155
Compare
Comment on lines
27
to
29
| const unusedAmountTotal = invoice.lines.data | ||
| .filter((line) => line.amount < 0) | ||
| .reduce((sum, line) => sum + line.amount, 0); |
There was a problem hiding this comment.
invoice.lines can contain a bunch of different things, and IMO it's risky to sum the amounts together on an invoice to get the unusedAmountTotal.
If the intention is to calculate the total proration, maybe consider making use of the invoice.lines.data.proration flag.
Comment on lines
31
to
37
| let unitAmount; | ||
| if (invoice.lines.data[invoice.lines.data.length - 1]) { | ||
| unitAmount = Number( | ||
| invoice.lines.data[invoice.lines.data.length - 1] | ||
| .unit_amount_excluding_tax | ||
| ); | ||
| } |
There was a problem hiding this comment.
Is it safe to assume the last item in invoice.lines will always provide the correct value?
xlisachan
force-pushed
the
FXA-11929
branch
4 times, most recently
from
833ab93 to
99f4115
Compare
xlisachan
changed the title
xlisachan
force-pushed
the
FXA-11929
branch
8 times, most recently
from
cfc3557 to
ddaa6ee
Compare
…ect amount due Because - the list price is being displayed instead of the price of the offering - on Subscription Management page, the total credit balance is deducted from all subscriptions - totals on Success page reflect upcoming invoice - emails are not displaying correct amount charged This pull request - updates the price of the offering from the list price to the unit amount - temporary removes inaccurate upcoming invoice total from Subscription Management - updates charged amount in email Closes: FXA-11929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11929
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.