Skip to content

task: audit yarn resolutions – protobufjs #19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

task: audit yarn resolutions – protobufjs #19106

wants to merge 1 commit into from
+0 −1

Conversation

toufali
Copy link
Member

@toufali toufali commented Jun 26, 2025

Because

  • Yarn resolutions should be used as last resort
  • pinning old packages prohibits security patches

This pull request

  • removes the resolution for protobufjs package

Issue that this pull request solves

Closes: FXA-11991

Other information

I confirm that before and after resolution removal, protobufjs resolves to 7.5.0 (satisfying the resolution). This is also why yarn.lock is unchanged.

@toufali toufali requested a review from a team as a code owner June 26, 2025 21:14
@toufali toufali force-pushed the resolution-protobufjs branch from de65294 to b2b3773 Compare June 27, 2025 21:04
dschom
dschom approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems like this was done to address a security alert with v6 protobuf package versions, which we aren't using anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschom dschom dschom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toufali @dschom