Skip to content

Bug 2010019 - Update to UniFFI 0.31 #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
badboy wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Bug 2010019 - Update to UniFFI 0.31 #3366

badboy wants to merge 6 commits into from

Conversation

@badboy
Copy link
Member

@badboy badboy commented Jan 5, 2026 •
edited
Loading

Currently running against main, but will be updated to use the release.

Fixes #3365

@badboy badboy changed the title Update to UniFFI 0.31 Bug 2010019 - Update to UniFFI 0.31 Jan 13, 2026
@badboy badboy marked this pull request as ready for review January 14, 2026 09:43
@badboy badboy requested a review from a team as a code owner January 14, 2026 09:43
@badboy badboy requested review from jeddai and removed request for a team January 14, 2026 09:43
@badboy
Copy link
Member Author

badboy commented Jan 14, 2026

/run-ios

@badboy badboy requested a review from travis79 January 14, 2026 10:06
@badboy badboy mentioned this pull request Jan 14, 2026
Merged
badboy
badboy commented Jan 14, 2026
View reviewed changes
.circleci/config.yml
Comment on lines +26 to +32
- msrv_image: &msrv-image
cimg/rust:1.87
- msrv: &msrv
"1.87"
# Used when running against latest stable Rust
- rust_image: &rust-image
cimg/rust:1.92
Copy link
Member Author

@badboy badboy Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had too many places where this is specified. It's easier to just use anchors and reuse them.

travis79
travis79 approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deserve a changelog entry. Normally I wouldn't ask for a dependency update but uniffi and Rust updates might be noteworthy? At the very least it could help in trying to remember when we updated something or let someone outside of our team with that.

Just a weak-opinion, no need to block on this

@badboy
Copy link
Member Author

badboy commented Jan 14, 2026

Does this deserve a changelog entry. Normally I wouldn't ask for a dependency update but uniffi and Rust updates might be noteworthy? At the very least it could help in trying to remember when we updated something or let someone outside of our team with that.

Just a weak-opinion, no need to block on this

guess it should!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@travis79 travis79 travis79 approved these changes

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner automatically assigned from mozilla/glean

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to UniFFI 0.31

3 participants

@badboy @travis79