Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aggregation_units to metric and datasource #553

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

mikewilli
Copy link
Collaborator

Step 1 towards supporting profile management feature.

  • adds support for aggregation_units to metrics and data_sources, and defaults both to what is currently supported, client_id only
  • ensures that the data_source supports (at least) all aggregations that the metric supports

@scholtzan
Copy link
Collaborator

I wonder if calling it group_by would be a better name?

@mikewilli
Copy link
Collaborator Author

To me group_by implies that we would group by the configured value(s). In this case, it's only meant to indicate which fields are supported as a group_by. Might still be fine / better than aggregation_units, but just concerned that people will think we are grouping by everything in the list. group_by_support maybe?

I'm definitely open to a different name though, and @danielkberry and I discussed it a bit already (analysis_units was another one we discussed).

Copy link
Contributor

@danielkberry danielkberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small suggestions and questions. I'm excited to incorporate this into my mozanalysis PR.

@danielkberry
Copy link
Contributor

There's just one open question, then I can re-review.

Copy link
Contributor

@danielkberry danielkberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the changes are made, thanks! LGTM

@mikewilli mikewilli added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit a931259 Aug 20, 2024
7 checks passed
@mikewilli mikewilli deleted the DS-3789-aggregation-level-support branch August 20, 2024 15:42
nuggetsnegin pushed a commit to nuggetsnegin/metric-hub that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants