Skip to content

CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC#440

Closed
dofuuz wants to merge 1 commit intomozilla:masterfrom
dofuuz:cmake-flags
Closed

CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC#440
dofuuz wants to merge 1 commit intomozilla:masterfrom
dofuuz:cmake-flags

Conversation

@dofuuz
Copy link
Contributor

@dofuuz dofuuz commented Dec 15, 2023

Fix #438
#403

  • Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC
  • Builds either shared or static at a time. Not both at once.

Building shared/static one by one and using BUILD_SHARED_LIBS is more standard way to using CMake.
https://cgold.readthedocs.io/en/latest/tutorials/libraries/static-shared.html

This going to fix shared/static libpng/zlib problem.

It may break existing automated builds.

- Builds either shared or static at a time. Not both at once.
@kornelski
Copy link
Member

Wow, I would not have guessed that a variable name can have a side effect.

@kornelski
Copy link
Member

Done in 38869c2

@kornelski kornelski closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZLIB & PNG are found... then not found...

2 participants