CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC#440
Closed
dofuuz wants to merge 1 commit intomozilla:masterfrom
Closed
CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC#440dofuuz wants to merge 1 commit intomozilla:masterfrom
dofuuz wants to merge 1 commit intomozilla:masterfrom
Conversation
- Builds either shared or static at a time. Not both at once.
Member
|
Wow, I would not have guessed that a variable name can have a side effect. |
Member
|
Done in 38869c2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #438
#403
Building shared/static one by one and using BUILD_SHARED_LIBS is more standard way to using CMake.
https://cgold.readthedocs.io/en/latest/tutorials/libraries/static-shared.html
This going to fix shared/static libpng/zlib problem.
It may break existing automated builds.